Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon won't allow config on enabled tab of NbRouteTabsetComponent #2337

Open
1 of 2 tasks
javiercampos opened this issue Apr 29, 2020 · 0 comments
Open
1 of 2 tasks

Icon won't allow config on enabled tab of NbRouteTabsetComponent #2337

javiercampos opened this issue Apr 29, 2020 · 0 comments

Comments

@javiercampos
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

According to #1935 (which closed #1323 ) , components which use icons should be accepting an icon config object (instead of just a string), however this commit 13d74cf is missing the change on the enabled tab template, so it only works for disabled tabs.

The fix should be easy, just change the line:

<nb-icon *ngIf="tab.icon" [icon]="tab.icon"></nb-icon>

to bind to the [config] property instead of [icon], as done on the disabled tab code a few lines above it on the specified commit:

<nb-icon *ngIf="tab.icon" [config]="tab.icon"></nb-icon>

Other information:

Tested on Angular 9 and nebular 5.0, but the problem is quite obvious that it's still there on master, and should be an easy fix (I really don't have time to make a pull request right now or I'd gladly do it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant