You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to #1935 (which closed #1323 ) , components which use icons should be accepting an icon config object (instead of just a string), however this commit 13d74cf is missing the change on the enabled tab template, so it only works for disabled tabs.
Tested on Angular 9 and nebular 5.0, but the problem is quite obvious that it's still there on master, and should be an easy fix (I really don't have time to make a pull request right now or I'd gladly do it)
The text was updated successfully, but these errors were encountered:
Issue type
I'm submitting a ... (check one with "x")
Issue description
According to #1935 (which closed #1323 ) , components which use icons should be accepting an icon config object (instead of just a string), however this commit 13d74cf is missing the change on the
enabled
tab template, so it only works for disabled tabs.The fix should be easy, just change the line:
nebular/src/framework/theme/components/route-tabset/route-tabset.component.ts
Line 105 in ac50dae
to bind to the
[config]
property instead of[icon]
, as done on thedisabled
tab code a few lines above it on the specified commit:nebular/src/framework/theme/components/route-tabset/route-tabset.component.ts
Line 91 in ac50dae
Other information:
Tested on Angular 9 and nebular 5.0, but the problem is quite obvious that it's still there on
master
, and should be an easy fix (I really don't have time to make a pull request right now or I'd gladly do it)The text was updated successfully, but these errors were encountered: