Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form field): addon alignment #2460

Merged
merged 5 commits into from
Jul 29, 2020
Merged

fix(form field): addon alignment #2460

merged 5 commits into from
Jul 29, 2020

Conversation

maksim-karatkevich
Copy link
Contributor

@maksim-karatkevich maksim-karatkevich commented Jul 24, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

fixes #2377

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #2460 into master will decrease coverage by 0.03%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##           master    #2460      +/-   ##
==========================================
- Coverage   81.48%   81.44%   -0.04%     
==========================================
  Files         244      244              
  Lines        7387     7399      +12     
  Branches      775      778       +3     
==========================================
+ Hits         6019     6026       +7     
- Misses       1138     1140       +2     
- Partials      230      233       +3     
Impacted Files Coverage Δ
.../theme/components/form-field/form-field-control.ts 66.66% <ø> (ø)
...heme/components/form-field/form-field.component.ts 31.57% <11.11%> (-1.76%) ⬇️
...mework/theme/components/select/select.component.ts 88.81% <50.00%> (-0.59%) ⬇️
...ramework/theme/components/input/input.directive.ts 89.33% <75.00%> (-0.95%) ⬇️
...ramework/theme/components/toastr/toastr.service.ts 97.39% <0.00%> (+2.60%) ⬆️

@yggg yggg changed the title fix(nbSuffix): fix suffix styling fix(form field): addon alignment Jul 29, 2020
@yggg yggg merged commit dc154ab into master Jul 29, 2020
@yggg yggg deleted the fix/nbSuffix-styling branch July 29, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbFormFieldModule nbSuffix out of bounds
2 participants