fix(calendar range cells): handle unset date or selectedValue #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `NbCalendarRangeDayCellComponent` `date` property could be
set to `null` in case it's from bounding month and user set
`boundingMonth` to false.
In all `NbCalendarRange*CellComponent` selectedValue could be defined
but has no `start` property set. It happens because users are setting
`[range]` input on `NbCalendarRangeComponent` to `{}` so `selectedValue`
is truthy.
First cd run occurs when picker class instantiated so changes made after in the `patchWithInputs` call won't be picked up.
As it affects bounding month cells. Depending on the `boundingMonths` value bounding month cells are set to `null` or `D`.
Codecov Report
@@ Coverage Diff @@
## master #2537 +/- ##
==========================================
+ Coverage 78.89% 78.94% +0.05%
==========================================
Files 253 253
Lines 7808 7809 +1
Branches 855 855
==========================================
+ Hits 6160 6165 +5
+ Misses 1384 1380 -4
Partials 264 264
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
d0850d4 is the main fix to handle
nulls indateandselecteValueproperties.datecould be null because of[boundingMonth]="false", see commit description for details.f5e2a82 and ad6442f are companion fixes for the issues I noticed when I was fixing the main issue.
f5e2a82 - input changes won't be picked up when the picker opens. See the commit description for details.
ad6442f - because
boundingMonthproperty value affects bounding monthdateproperty, day picker should regenerateweekswhen property change. See the commit description for details.