Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag component #2565

Merged
merged 6 commits into from
Jan 18, 2021
Merged

feat: tag component #2565

merged 6 commits into from
Jan 18, 2021

Conversation

SFilinsky
Copy link
Contributor

@SFilinsky SFilinsky commented Oct 22, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Adds Tag component

feat: added tag showcase
feat: added tag status showcase
@ghost
Copy link

ghost commented Oct 22, 2020

DeepCode's analysis on #7e3b6c found:

  • ℹ️ 2 minor issues. 👇

Top issues

Description Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes
Type boolean trivially inferred from a boolean literal, remove type annotation Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@yggg yggg changed the title feat: added tag components feat: tag component Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #2565 (7e3b6cf) into master (d10275b) will decrease coverage by 1.62%.
The diff coverage is 25.30%.

@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
- Coverage   79.09%   77.47%   -1.63%     
==========================================
  Files         258      262       +4     
  Lines        7966     8213     +247     
  Branches      872      894      +22     
==========================================
+ Hits         6301     6363      +62     
- Misses       1391     1576     +185     
  Partials      274      274              
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 86.82% <0.00%> (ø)
...amework/theme/components/tag/tag-list.component.ts 19.70% <19.70%> (ø)
...mework/theme/components/tag/tag-input.directive.ts 25.00% <25.00%> (ø)
...rc/framework/theme/components/tag/tag.component.ts 32.14% <32.14%> (ø)
.../components/autocomplete/autocomplete.directive.ts 83.12% <100.00%> (+0.10%) ⬆️
src/framework/theme/components/tag/tag.module.ts 100.00% <100.00%> (ø)

yggg
yggg previously approved these changes Jan 18, 2021
@yggg yggg merged commit bcdfcd8 into akveo:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants