-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): add custom comparator input #2590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue #2543 |
Codecov Report
@@ Coverage Diff @@
## master #2590 +/- ##
==========================================
- Coverage 78.95% 78.94% -0.01%
==========================================
Files 253 253
Lines 7815 7819 +4
Branches 857 857
==========================================
+ Hits 6170 6173 +3
- Misses 1382 1383 +1
Partials 263 263
|
DeepCode's analysis on #a58e55 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
hello @yggg. is there any chance for this functionality to be added in a next release of nebular? |
As it's the same as property type
To be same as Angular native input name
yggg
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ascripcaru!
yggg
pushed a commit
that referenced
this pull request
Dec 24, 2020
(cherry picked from commit 1f8a57b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Select options only worked when using primitives as values. If you had to use objects the
===
could not cope with the complex values. Thus, I added the possibility to add a custom compare function as a parameter for nebular select for more complex use cases and kept the old functionality in place.Closes #2543. Closes #1223. Closes #1858.