Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): emit state change #2645

Merged
merged 1 commit into from
Jan 18, 2021
Merged

fix(sidebar): emit state change #2645

merged 1 commit into from
Jan 18, 2021

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jan 18, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #2645 (03ac2bd) into master (d10275b) will decrease coverage by 1.61%.
The diff coverage is 26.19%.

@@            Coverage Diff             @@
##           master    #2645      +/-   ##
==========================================
- Coverage   79.09%   77.48%   -1.62%     
==========================================
  Files         258      262       +4     
  Lines        7966     8216     +250     
  Branches      872      894      +22     
==========================================
+ Hits         6301     6366      +65     
- Misses       1391     1576     +185     
  Partials      274      274              
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 86.82% <0.00%> (ø)
...amework/theme/components/tag/tag-list.component.ts 19.70% <19.70%> (ø)
...mework/theme/components/tag/tag-input.directive.ts 25.00% <25.00%> (ø)
...rc/framework/theme/components/tag/tag.component.ts 32.14% <32.14%> (ø)
.../components/autocomplete/autocomplete.directive.ts 83.12% <100.00%> (+0.10%) ⬆️
...work/theme/components/sidebar/sidebar.component.ts 58.27% <100.00%> (+0.92%) ⬆️
src/framework/theme/components/tag/tag.module.ts 100.00% <100.00%> (ø)
... and 1 more

@yggg yggg merged commit 8a35e85 into akveo:master Jan 18, 2021
@yggg yggg deleted the fix/sidebar-emit-state-change-event-on-methods branch January 18, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant