Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): save lastInputValue when changed via form api #2718

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

unumtresocto
Copy link
Contributor

@unumtresocto unumtresocto commented Apr 20, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2629

@unumtresocto unumtresocto requested a review from yggg April 20, 2021 11:54
@unumtresocto unumtresocto changed the title fix(radio): save lastInputValue when timepicker dialog is shown fix(timepicker): save lastInputValue when timepicker dialog is shown Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2718 (3d648fd) into master (002adc2) will decrease coverage by 6.80%.
The diff coverage is 75.49%.

❗ Current head 3d648fd differs from pull request most recent head 2e94b72. Consider uploading reports for the commit 2e94b72 to get more accurate results

@@            Coverage Diff             @@
##           master    #2718      +/-   ##
==========================================
- Coverage   84.57%   77.76%   -6.81%     
==========================================
  Files         235      262      +27     
  Lines        8059     8231     +172     
  Branches      710      896     +186     
==========================================
- Hits         6816     6401     -415     
- Misses       1023     1556     +533     
- Partials      220      274      +54     
Impacted Files Coverage Δ
src/framework/auth/components/auth.component.ts 28.57% <0.00%> (-15.88%) ⬇️
...framework/auth/strategies/auth-strategy-options.ts 100.00% <ø> (ø)
.../auth/strategies/oauth2/oauth2-strategy.options.ts 100.00% <ø> (ø)
...ramework/auth/strategies/oauth2/oauth2-strategy.ts 83.57% <ø> (-1.10%) ⬇️
...work/auth/strategies/password/password-strategy.ts 97.59% <ø> (-0.24%) ⬇️
...ponents/accordion/accordion-item-body.component.ts 46.15% <0.00%> (-12.67%) ⬇️
...nents/accordion/accordion-item-header.component.ts 40.00% <0.00%> (-8.28%) ⬇️
...e/components/accordion/accordion-item.component.ts 28.57% <0.00%> (-9.73%) ⬇️
.../theme/components/accordion/accordion.component.ts 41.66% <ø> (-11.67%) ⬇️
...eme/components/calendar-kit/calendar-kit.module.ts 100.00% <ø> (ø)
... and 322 more

@yggg yggg changed the title fix(timepicker): save lastInputValue when timepicker dialog is shown fix(timepicker): save lastInputValue when changed via form api Jun 15, 2021
@yggg yggg merged commit 74096d0 into akveo:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbTimePickerDirective: Should persist initial time set via a FormControl on focus -> unfocus
2 participants