Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/select #698

Merged
merged 43 commits into from
Sep 12, 2018
Merged

Feature/select #698

merged 43 commits into from
Sep 12, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Sep 7, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #671

Tibing and others added 30 commits August 27, 2018 16:52
@Tibing Tibing requested a review from yggg September 7, 2018 13:54
src/framework/theme/components/select/option.component.ts Outdated Show resolved Hide resolved
src/framework/theme/components/select/option.component.ts Outdated Show resolved Hide resolved
src/framework/theme/styles/global/_components.scss Outdated Show resolved Hide resolved
NbDialogModule,
NbBadgeModule,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why rearrange?

src/playground/select/select-multiple.component.ts Outdated Show resolved Hide resolved
src/playground/select/select-showcase.component.ts Outdated Show resolved Hide resolved
docs/structure.ts Outdated Show resolved Hide resolved
@nnixaa nnixaa merged commit d6a211f into akveo:master Sep 12, 2018
@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #698 into master will increase coverage by 2.03%.
The diff coverage is 90.17%.

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   72.96%   74.99%   +2.03%     
==========================================
  Files         179      183       +4     
  Lines        4867     5091     +224     
  Branches      368      385      +17     
==========================================
+ Hits         3551     3818     +267     
+ Misses       1244     1193      -51     
- Partials       72       80       +8
Impacted Files Coverage Δ
...framework/theme/components/select/select.module.ts 100% <100%> (ø)
...k/theme/components/cdk/overlay/overlay-position.ts 84.61% <83.33%> (+32.85%) ⬆️
...mework/theme/components/select/select.component.ts 88.19% <88.19%> (ø)
.../theme/components/select/option-group.component.ts 90% <90%> (ø)
...mework/theme/components/select/option.component.ts 97.05% <97.05%> (ø)
...mework/theme/components/layout/layout.component.ts 78.31% <0%> (+2.4%) ⬆️
... and 4 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component - dropdown
3 participants