-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/select #698
Merged
Merged
Feature/select #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibing
force-pushed
the
feature/select
branch
from
September 11, 2018 18:00
3fd8649
to
339fb91
Compare
nnixaa
requested changes
Sep 11, 2018
src/framework/theme/components/select/_select.component.theme.scss
Outdated
Show resolved
Hide resolved
src/framework/theme/components/select/option-group.component.ts
Outdated
Show resolved
Hide resolved
src/playground/playground.module.ts
Outdated
NbDialogModule, | ||
NbBadgeModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why rearrange?
nnixaa
requested changes
Sep 11, 2018
Tibing
force-pushed
the
feature/select
branch
from
September 11, 2018 21:42
949a708
to
2b6b78c
Compare
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 72.96% 74.99% +2.03%
==========================================
Files 179 183 +4
Lines 4867 5091 +224
Branches 368 385 +17
==========================================
+ Hits 3551 3818 +267
+ Misses 1244 1193 -51
- Partials 72 80 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #671