Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): item click now just Subject, no ReplaySubject #724

Merged
merged 3 commits into from
Sep 20, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Sep 18, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

The NbMenuService not reply the last click event.

To Update:
if you use the knowledge that the last click event is replied you can wrap onItemClick stream in the custom stream based on ReplaySubject.

Closes #695

@nnixaa
Copy link
Collaborator

nnixaa commented Sep 19, 2018

@Tibing do we need to test it in any way? Are you sure it is not breaking anything?

@nnixaa nnixaa merged commit eb6e74b into akveo:master Sep 20, 2018
@Tibing Tibing mentioned this pull request Sep 26, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnItemClick stored in ReplaySubject cause logout right after login
2 participants