feat(notfound): add NotFound component #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirects users who hit an unknown page to a custom component Fixes akveo#1410
dizco
force-pushed
the
dizco-page-not-found
branch
from
2cc6187
to
e68c00b
Compare
|
Hey @dizco, great addition!
Also, I would suggest a bit of a refactoring - let's move the comonent from |
nnixaa
reviewed
May 3, 2018
| @@ -35,6 +36,9 @@ const routes: Routes = [{ | |||
| path: '', | |||
| redirectTo: 'dashboard', | |||
| pathMatch: 'full', | |||
| }, { | |||
| path: '**', | |||
| component: PageNotFoundComponent, | |||
There was a problem hiding this comment.
Also, let's name it NotFoundComponent as the other pages don't have a Page prefix.
|
@nnixaa what would you think of Miscellaneous instead of Other? Also thought of Extra. |
|
|
Added a direct link in the menu, and move the component to Miscellaneous folder
|
Choice of icons isn't my particular strength, so please feel free to suggest something better if there is haha!
|
dizco
changed the title
nnixaa
requested changes
May 4, 2018
| import { NgModule } from '@angular/core'; | ||
| import { Routes, RouterModule } from '@angular/router'; | ||
|
|
||
| import {MiscellaneousComponent} from './miscellaneous.component'; |
There was a problem hiding this comment.
@dizco let's add the spaces
|
@dizco cool! Merging now. |
nnixaa
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request (check one with "x"):
Short description of what this resolves:
Redirects users who hit an unknown page to a custom component
Fixes #1410
A couple of things I was not too sure about :