-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notfound): add NotFound component #1672
Conversation
Redirects users who hit an unknown page to a custom component Fixes akveo#1410
2cc6187
to
e68c00b
Compare
Hey @dizco, great addition!
Also, I would suggest a bit of a refactoring - let's move the comonent from |
@@ -35,6 +36,9 @@ const routes: Routes = [{ | |||
path: '', | |||
redirectTo: 'dashboard', | |||
pathMatch: 'full', | |||
}, { | |||
path: '**', | |||
component: PageNotFoundComponent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's name it NotFoundComponent
as the other pages don't have a Page
prefix.
@nnixaa what would you think of Miscellaneous instead of Other? Also thought of Extra. |
|
Added a direct link in the menu, and move the component to Miscellaneous folder
import { NgModule } from '@angular/core'; | ||
import { Routes, RouterModule } from '@angular/router'; | ||
|
||
import {MiscellaneousComponent} from './miscellaneous.component'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dizco let's add the spaces
@dizco cool! Merging now. |
Please read and mark the following check list before creating a pull request (check one with "x"):
Short description of what this resolves:
Redirects users who hit an unknown page to a custom component
Fixes #1410
A couple of things I was not too sure about :