Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultProps from MeasureElement component #1818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rklomp
Copy link

@rklomp rklomp commented May 24, 2024

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Resolves #1813

@Atsukoro1
Copy link

Please review this, the error is really annoying and it will destroy the library in future

@rklomp
Copy link
Author

rklomp commented May 31, 2024

@greenfrvr, Are you still involved with this repo?

@rklomp
Copy link
Author

rklomp commented Jun 19, 2024

@elupanov

@greenfrvr
Copy link
Member

Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.

@rklomp
Copy link
Author

rklomp commented Jun 20, 2024

Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.

MeasureElement is the only function component I could find using defaultProps. The others are class components.

@vilnytskyi
Copy link

@greenfrvr please merge this one, as defaultProps in class components are still acceptable to use for now.

@vilnytskyi
Copy link

I've posted a workaround to fix this one and #1782 until this PR is approved

@rklomp
Copy link
Author

rklomp commented Jul 21, 2024

@greenfrvr, can you merge this and release a new version?

@felixsebastian
Copy link

bump, this should be an easy fix boys

@rklomp
Copy link
Author

rklomp commented Aug 10, 2024

Looks like UI Kitten is dead.

@dragospeta
Copy link

Too bad... it's one of the best UI libraries out there i think.

@ckeating99
Copy link

+1 @greenfrvr

@rklomp
Copy link
Author

rklomp commented Aug 25, 2024

@KostyaDanovsky @elupanov @malashkevich @lugovsky @SashaSkywalker @greenfrvr @sashaqred @Tibing @32penkin @mmfKupl

Can anyone merge this or confirm UI Kitten is officially dead?

@evansendra
Copy link

+1

Copy link

@agenttux agenttux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just merge this in big dawg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaultprops warning when using OverflowMenu