Resync the package with the most recent developments in packages SparseArray and DelayedArray #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alanocallaghan,
Even though scater 1.33.2 is mostly green on the BioC 3.20 daily build report, a few things are out of date with the current devel versions of SparseArray and DelayedArray. In particular:
[
,colSums()
,colMeans()
, etc...) very efficiently, and, for almost all the operations that they support, SVT_SparseArray objects outperform dgCMatrix objects. So most of the time it's preferrable to coerce to SVT_SparseArray than to dgCMatrix.This patch removes references to the SparseArraySeed class and takes advantage of the efficiency of SVT_SparseArray objects. It also updates a few outdated
importFrom
statements.Let me know if you have questions.
Best,
H.