Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seconds might be too much on event times? #2

Closed
jonbloor opened this issue Jan 23, 2025 · 1 comment · Fixed by #5
Closed

Seconds might be too much on event times? #2

jonbloor opened this issue Jan 23, 2025 · 1 comment · Fixed by #5
Assignees
Labels
enhancement New feature or request

Comments

@jonbloor
Copy link

I decided to remove seconds on the time output:

/template/shortcode/events.php becomes:

Start Date/Time End Date/Time Name Location
format('d M Y') ) . ' ' . esc_html( date( 'H:i', strtotime( $event['starttime'] ) ) ); ?> format('d M Y') ) . ' ' . esc_html( date( 'H:i', strtotime( $event['endtime'] ) ) ); ?>
@alantiller alantiller self-assigned this Jan 23, 2025
@alantiller alantiller added the enhancement New feature or request label Jan 23, 2025
@alantiller
Copy link
Owner

I completely understand that seconds might be unnecessary. Instead of removing them entirely, I plan to add an Advanced Options page. On this page, there will be an option to configure the date and time layout. The default setting will exclude seconds, but users who prefer to have them can add them back.

@alantiller alantiller linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants