diff --git a/server/src/main/java/org/elasticsearch/common/settings/SettingsModule.java b/server/src/main/java/org/elasticsearch/common/settings/SettingsModule.java index 2f2e4367e1930..346a474b4b4aa 100644 --- a/server/src/main/java/org/elasticsearch/common/settings/SettingsModule.java +++ b/server/src/main/java/org/elasticsearch/common/settings/SettingsModule.java @@ -37,7 +37,6 @@ public class SettingsModule implements Module { private final Set settingsFilterPattern = new HashSet<>(); private final Map> nodeSettings = new HashMap<>(); private final Map> indexSettings = new HashMap<>(); - private final Set> consistentSettings = new HashSet<>(); private final IndexScopedSettings indexScopedSettings; private final ClusterSettings clusterSettings; private final SettingsFilter settingsFilter; @@ -161,19 +160,6 @@ private void registerSetting(Setting setting) { if (existingSetting != null) { throw new IllegalArgumentException("Cannot register setting [" + setting.getKey() + "] twice"); } - if (setting.isConsistent()) { - if (setting instanceof Setting.AffixSetting) { - if (((Setting.AffixSetting) setting).getConcreteSettingForNamespace("_na_") instanceof SecureSetting) { - consistentSettings.add(setting); - } else { - throw new IllegalArgumentException("Invalid consistent secure setting [" + setting.getKey() + "]"); - } - } else if (setting instanceof SecureSetting) { - consistentSettings.add(setting); - } else { - throw new IllegalArgumentException("Invalid consistent secure setting [" + setting.getKey() + "]"); - } - } nodeSettings.put(setting.getKey(), setting); } if (setting.hasIndexScope()) { @@ -181,9 +167,6 @@ private void registerSetting(Setting setting) { if (existingSetting != null) { throw new IllegalArgumentException("Cannot register setting [" + setting.getKey() + "] twice"); } - if (setting.isConsistent()) { - throw new IllegalStateException("Consistent setting [" + setting.getKey() + "] cannot be index scoped"); - } indexSettings.put(setting.getKey(), setting); } } else { @@ -224,10 +207,6 @@ public ClusterSettings getClusterSettings() { return clusterSettings; } - public Set> getConsistentSettings() { - return consistentSettings; - } - public SettingsFilter getSettingsFilter() { return settingsFilter; } diff --git a/server/src/main/java/org/elasticsearch/node/NodeConstruction.java b/server/src/main/java/org/elasticsearch/node/NodeConstruction.java index 6219bff8d2a30..9188b83aa11eb 100644 --- a/server/src/main/java/org/elasticsearch/node/NodeConstruction.java +++ b/server/src/main/java/org/elasticsearch/node/NodeConstruction.java @@ -217,7 +217,6 @@ import java.util.Map; import java.util.Objects; import java.util.Optional; -import java.util.Set; import java.util.concurrent.TimeUnit; import java.util.function.Function; import java.util.stream.Collectors; @@ -1170,13 +1169,6 @@ private ClusterService createClusterService(SettingsModule settingsModule, Threa taskManager ); resourcesToClose.add(clusterService); - - Set> consistentSettings = settingsModule.getConsistentSettings(); - if (consistentSettings.isEmpty() == false) { - clusterService.addLocalNodeMasterListener( - new ConsistentSettingsService(settingsModule.getSettings(), clusterService, consistentSettings).newHashPublisher() - ); - } return clusterService; }