-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more transforms to benchmark #5
Conversation
Reviewer's Guide by SourceryThis pull request adds more image transforms to the benchmark suite and includes code formatting improvements. The changes focus on expanding the test coverage by implementing additional transforms in the imgaug and torchvision libraries, while also improving code quality through consistent formatting and style. Class diagram for TransformSpec modificationsclassDiagram
class TransformSpec {
+String name
+dict[str, Any] params
+String __str__()
}
note for TransformSpec "Base class that defines exact parameters for each transform"
class TransformSpecList {
+TransformSpec[] TRANSFORM_SPECS
}
note for TransformSpecList "List of all transform specifications based on the original implementations"
Class diagram for TorchvisionImpl modificationsclassDiagram
class TorchvisionImpl {
+static Transform HorizontalFlip(dict[str, Any] params)
+static Transform VerticalFlip(dict[str, Any] params)
+static Transform Rotate(dict[str, Any] params)
+static Transform Affine(dict[str, Any] params)
+static Transform Equalize(dict[str, Any] params)
+static Transform RandomCrop80(dict[str, Any] params)
+static Transform RandomResizedCrop(dict[str, Any] params)
+static Transform Resize(dict[str, Any] params)
+static Transform ColorJitter(dict[str, Any] params)
+static Transform RandomPerspective(dict[str, Any] params)
+static Transform GaussianBlur(dict[str, Any] params)
+static Transform Posterize(dict[str, Any] params)
+static Transform Elastic(dict[str, Any] params)
+static Transform Normalize(dict[str, Any] params)
+static Transform Brightness(dict[str, Any] params)
+static Transform Contrast(dict[str, Any] params)
+static Transform JpegCompression(dict[str, Any] params)
}
note for TorchvisionImpl "Torchvision implementations of transforms"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add new transforms to the benchmark suite, including Clahe, CoarseDropout, Blur, Brightness, and Contrast. Improve the formatting of transform specifications and enhance the benchmark runner for better error handling and logging. Update documentation with new performance results.
New Features:
Enhancements:
Documentation: