Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldComposer TODO #2

Closed
11 of 19 tasks
wiktor-obrebski opened this issue Mar 9, 2019 · 3 comments
Closed
11 of 19 tasks

WorldComposer TODO #2

wiktor-obrebski opened this issue Mar 9, 2019 · 3 comments

Comments

@wiktor-obrebski
Copy link
Contributor

wiktor-obrebski commented Mar 9, 2019

  • map settings
  • solids positions manual control
  • control fluid sources/sinks
  • simulation time step factor
  • simulation computational accuracy factor
  • control external forces
  • try to move simulation to background thread
  • add webgl renderer
  • play/pause button
  • display fluid sources/sink on map
  • change map size
  • add forces by dragging?
  • change render size (zoom)
  • fix sinks close-to-wall bug

Cleanup:

  • refactor statistics
  • restore pressure view
  • fix simulations unit tests
  • refactor App.ts
  • think about drop React components in favor of plain functions on PixelImageData renderers (for performance and simplicity)
@wiktor-obrebski
Copy link
Contributor Author

Web workers tests summary:

  • not supported yet without eject in CRA: WIP: Add support for WebWorker with worker-loader facebook/create-react-app#5886
  • in standard case data are shared by copy. as we need to handle thousands of particles and update them dozens times per second, the copy mechanism starts to be significant blocker
  • there is a "Transferable" way of sharing data in newest Chrome. it allow as that second thread not only update given particles, but even prepare draw buffer to be renderer on main thread later
  • generally, it's interesting topic and I should back to it in the future. currently prefer to spend time somewhere else (and not ejecting entire app)

@wiktor-obrebski
Copy link
Contributor Author

webgl renderer summary:

  • after some test I decided that there is too big learning cost to do it right and not enough to gain. currently rendering isn't any real problem, recalculating particles positions is bottleneck

@wiktor-obrebski wiktor-obrebski changed the title TODO WorldComposer TODO May 31, 2020
@wiktor-obrebski
Copy link
Contributor Author

I focusing on main project currently, abandoning this toy project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant