Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running a single bench from a file #58

Open
arjan opened this issue Feb 26, 2017 · 8 comments
Open

Allow running a single bench from a file #58

arjan opened this issue Feb 26, 2017 · 8 comments

Comments

@arjan
Copy link

arjan commented Feb 26, 2017

Similar to mix test file:line, e.g.:

mix bench bench/template_bench.exs:37

@alco
Copy link
Owner

alco commented Feb 26, 2017

Would you like to send a PR implementing this feature? :)

@arjan
Copy link
Author

arjan commented Feb 26, 2017

Sure, need to find some time for it though :)

@jdemaris
Copy link
Contributor

Doesn't this already work? When I specify a file, it runs exactly that one for me with the current version:

mix bench bench/graph.exs

It only runs that single bench file and not others. That is handled in the paths param that is processed here: https://github.com/alco/benchfella/blob/master/lib/mix/tasks/bench.ex#L100

@arjan
Copy link
Author

arjan commented Jul 21, 2017

Yes but this is about running just one benchmark from a particular file. (you can have multiple benchmarks in a single file).

So adding a colon and the line number to the path argument.

@arjan
Copy link
Author

arjan commented Jul 21, 2017

I created a PR for this a while back, see #59.

@jdemaris
Copy link
Contributor

Oh!!! Nice!! Yea, I saw the PR but I overlooked the details in the original comment. 👍

Any idea if this is still being maintained? I am starting to use it regularly.

@arjan
Copy link
Author

arjan commented Jul 22, 2017

I'm not sure... @alco ?

https://github.com/PragTob/benchee seems to be getting more love..

@jdemaris
Copy link
Contributor

Yea unfortunately Benchee takes a different approach and everything is centered around comparing different ways of doing the same thing. It really did not fit my benchmarking needs.

I may just have to fork benchfella so we can maintain this. Benchfella is great for exactly what we needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants