Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release on crates.io #35

Open
x-hgg-x opened this issue Apr 18, 2022 · 6 comments
Open

New release on crates.io #35

x-hgg-x opened this issue Apr 18, 2022 · 6 comments

Comments

@x-hgg-x
Copy link

x-hgg-x commented Apr 18, 2022

Hello, can you make a new release on crates.io which includes the fix for #28 ?

@Shnatsel
Copy link
Contributor

@aldanor could you publish a new release of fast-float to crates.io with the fix for #28?

I understand the fix is already merged and you just need to cargo publish.

@jqnatividad
Copy link

jqnatividad commented Oct 30, 2024

+1 on a new release please @aldanor .

It's been more than 4 years since 0.2.0 was released and there are still pending unreleased fixes.

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Oct 30, 2024

Would there be interest in me forking this and maintaining it as fast-float2? I'm the external contributor I believe who has done the most work on this and it seems this is no longer maintained, so I could merge the pending PRs and issue fixes and draft additional releases.

Ideally, users could just migrate to Rust std library implementation but for partial float parsing, that would be a nice alternative.

@Alexhuszagh
Copy link
Contributor

Alexhuszagh commented Oct 30, 2024

This has been forked @jqnatividad to fast-float2. It currently has no changes other than a migration to 0.2.1 and the patches mentioned here. I'll add additional patches for the unsoundness soon. I'll submit a PR to rustsec about this and potentially detach my fork in the future.

https://github.com/Alexhuszagh/fast-float-rust
https://crates.io/crates/fast-float2

@jqnatividad
Copy link

jqnatividad commented Oct 30, 2024

Thanks @Alexhuszagh ! This crate is widely used by other high-visibility crates like polars.
https://crates.io/crates/fast-float/reverse_dependencies

Thanks for stepping up!

@Alexhuszagh
Copy link
Contributor

I need to do a few security soundness patches related to #37 which should be relatively trivial to implement just to ensure local safety invariants are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants