Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.PlaceholderFormat should not be required on .Upsert() method. #10

Closed
aldy505 opened this issue Nov 5, 2021 · 0 comments · Fixed by #11
Closed

.PlaceholderFormat should not be required on .Upsert() method. #10

aldy505 opened this issue Nov 5, 2021 · 0 comments · Fixed by #11

Comments

@aldy505
Copy link
Owner

aldy505 commented Nov 5, 2021

Calling .PlaceholderFormat() method when doing .Upsert() is useless because the users have already specified the database dialect for it.

To keep it backward compatible, just make it optional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make PlaceholderFormat not required aldy505/bob
1 participant
@aldy505