Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Email Regex to not match on extra characters #447

Closed
Tankanow opened this issue Sep 20, 2021 · 1 comment
Closed

Fix Email Regex to not match on extra characters #447

Tankanow opened this issue Sep 20, 2021 · 1 comment

Comments

@Tankanow
Copy link
Contributor

Change email regex match to fullmatch

This PR is about the current method used to conditionally match user and domain regex to email.
currently, it's using match which wrongfully accepts entries if domain has special characters after .com

it currently accepts, john@voluptuous.com> or john!@voluptuous.org!@($*!

thus, we need to fullmatch the domain or user to avoid such entries and validate them properly.

@Tankanow
Copy link
Contributor Author

I created this issue just for bookkeeping with the latest commit already on master: e5e3b51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant