Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Bookmarks fail if file has unstaged changes in git and already bookmarked when opened #40

Closed
duanehutchins opened this issue Oct 20, 2016 · 1 comment
Labels
bug sticky Relative to the Sticky feature
Milestone

Comments

@duanehutchins
Copy link

To reproduce this issue,

  1. Enable bookmarks.useStickyBookmarks = true (I also have "editor.trimAutoWhitespace": false, but the bug persists with or without it)
  2. Create a file and add it into git so that it's tracked.
  3. Open the file in vscode and change it. Save the changes but don't stage the changes in git.
  4. Add a bookmark on the file.
  5. Close the file and then open it again.
  6. Make a change to the file above the line that's bookmarked. The bookmark moves or fails.

Here's a gif of the bug in action. Note the lines indicating that the file is currently versioned and changed in git.

The bookmark works at first; it only fails after closing the file and reopening it:
vscodebookmarkissue

@alefragnani alefragnani added the bug label Nov 2, 2016
@alefragnani
Copy link
Owner

Hi @duanehutchins ,

I'm sorry taking so long to answer. I saw your post but forgot to give the proper attention because of other projects 😢.

I think this problem may be related to #33, which is my next priority in the extension. I hope to be able to focus on this in the next week. So, stay tuned 😄 .

@alefragnani alefragnani added the sticky Relative to the Sticky feature label Feb 6, 2017
@alefragnani alefragnani added this to the 0.12.0 milestone Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sticky Relative to the Sticky feature
Projects
None yet
Development

No branches or pull requests

2 participants