Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark icons are missing #43

Closed
brentonhouse opened this issue Dec 1, 2016 · 13 comments
Closed

Bookmark icons are missing #43

brentonhouse opened this issue Dec 1, 2016 · 13 comments
Labels
bug good first issue Good for newcomers

Comments

@brentonhouse
Copy link

The bookmarks function properly but there is no indicator. Using version 1.7.2 on OS X.

@alefragnani alefragnani added the bug label Dec 1, 2016
@alefragnani
Copy link
Owner

Hi @brentonhouse ,

It seems the same issue reported sometime ago (#34), caused by a bug in VSCode. It should be fixed now, at least in version 0.9.2 of the extension.

Are your extension updated?

@brentonhouse
Copy link
Author

I am running version 0.10 of plugin.

@alefragnani
Copy link
Owner

Could you take a look at the debug?

Open Help / Toggle Developer Tools and click in Console and check if there is any message about the extension. If you find, paste the message here.

@brentonhouse
Copy link
Author

no messages...

@alefragnani
Copy link
Owner

In this case, I suggest you to reinstall the extension. Maybe something went wrong and the resources were not properly downloaded/installed.

But before that, you could check the extension files. You just need to open the extensions folder (Command Palette / Open Extensions Folder), then navigate to alefragnani.Bookmarks. It should exists a folder called images and inside of it you should have a file called bookmark.png. This is the image to be displayed in the gutter.

Another thing that I remembered is about the Themes. Right at the beginning I noted a bug in _High Contrast _ thene. It was fixed in VSCode core. Are you using any custom Theme?

Hope this helps.

@alefragnani
Copy link
Owner

Hi @brentonhouse , any news?

@brentonhouse
Copy link
Author

Tried uninstalling/reinstalling. Also verified that the image exists in folder. I am also not using high contrast theme. No luck...

@brentonhouse
Copy link
Author

It was working for me a while back (before I opened ticket) but not since.

@alefragnani
Copy link
Owner

I'm sorry about it. Unfortunately I don't have a Mac in hand to test (if this is OS related). I will try to get one from a friend and see if this happens there.

Let me know of any updates..

@alefragnani alefragnani added the good first issue Good for newcomers label Jan 10, 2017
@alefragnani
Copy link
Owner

Hi @brentonhouse , are you still experiencing this issue? If yes, just out of curiosity, are you using a Retina Mac?

I remembered your issue when looking for #70 . Maybe, if that is the case, could fix your issue too.

@alefragnani
Copy link
Owner

Just released version 0.15.0 supporting SVG image as bookmarks.
Could you check it?

@brentonhouse
Copy link
Author

I've uninstalled and reinstalled but keep getting 0.14.1. I will try again tomorrow to see if it is cached somewhere. Thanks!

@brentonhouse
Copy link
Author

Looks like 0.15.0 works!!! Thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants