Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Terminal content lost when switch back to project #460

Closed
turgs opened this issue Jan 26, 2021 · 6 comments
Closed

[BUG] - Terminal content lost when switch back to project #460

turgs opened this issue Jan 26, 2021 · 6 comments
Labels
caused by vscode The issue was caused by a VS Code (update) out of scope question

Comments

@turgs
Copy link

turgs commented Jan 26, 2021

in my projects I usually have multiple Terminal panes running.

These expectedly disappear when switching projects, but switching back doesn't restore my previous terminal content.

@turgs turgs added the bug label Jan 26, 2021
@alefragnani
Copy link
Owner

Hi @turgs ,

The Project Manager extension does not save or restore any session information. Everything you see restored, is made by VS Code itself, and right now, VS Code does not support restoring Terminal sessions, as you can see in this issue (microsoft/vscode#20013), opened in VS Code repo.

I suggest you to upvote that issue, to give higher visibility to the VS Code team.

Hope this helps

@alefragnani alefragnani added out of scope question caused by vscode The issue was caused by a VS Code (update) and removed bug labels Jan 27, 2021
@pudgereyem
Copy link

@alefragnani it seems like VS Code did fix the issue you mentioned, see comment here. An update from VS Code can be seen here, which reads:

Local terminal processes are now restored on window reload, such as when an extension install requires a reload. The terminal will be reconnected and the UI state of the terminals will be restored, including the active tab and split terminal relative dimensions.

However this didn't fix the issue where terminal content is lost when switching back to a project. Thinking that it makes sense to re-open this issue?

Thanks for the great work!

@alefragnani
Copy link
Owner

Hi @pudgereyem ,

Looking closer at the issue, I've noticed it talks about window reloads only, without mentioning restore (which is what happens when you switch back to previous opened projects/windows). So yes, switching between projects (restore previous projects) does not work.

But, If you do the same thing using Open Recent command, you will notice VS Code does not restore the Terminal sessions.

I didn't find a proper issue in VS Code repo (did a quick search) but as previously mentioned, this behavior is controlled by VS Code, not the extension. The extension only opens the desired project (using the native openFolder command) so any state VS Code has, is saved/restored by VS Code itself.

I'll try to find an open issue and link here. I would ask you to search too and if you find, please link as well.

Hope this helps

@pudgereyem
Copy link

@alefragnani that makes sense! I switched to open projects in a new window instead since I can't loose my terminals.

All the best,
Victor

@alefragnani
Copy link
Owner

I found this one (microsoft/vscode#44302), but was closes as out of scope. I didn't dig too much, but if I understand correctly, it appears the team will not support that. But, some comments were added with new extensions to support that. Maybe some of that could work for you.

@LukeDickerson19
Copy link

+1 for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caused by vscode The issue was caused by a VS Code (update) out of scope question
Projects
None yet
Development

No branches or pull requests

4 participants