{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":545324848,"defaultBranch":"master","name":"installer","ownerLogin":"aleskandro","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-10-04T07:00:27.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13661032?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1720189569.0","currentOid":""},"activityList":{"items":[{"before":"adead6e16467dcbb935057e2861d393bcc8bd1a2","after":"6f68a51829af23bf755dbbc033187b1be3c1fff4","ref":"refs/heads/scos-mitigations","pushedAt":"2024-07-05T16:45:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Remove the mitigations parameter in SCOS installations to force kernel defaults\n\nCurrently, OKD/SCOS is installed using FCOS boot images. FCOS boot images override the default setting for the mitigations parameter, disabling SMT in Intel-based machines.\nThis leads the installation to fail with the default machine types in AWS.\nThis commit will add the KernelArguments stanza to the ignition for the master and worker nodes, in order to remove the kernel parameter mitigations=auto,nosmt.","shortMessageHtmlLink":"Remove the mitigations parameter in SCOS installations to force kerne…"}},{"before":"1bf976958ae4231ca0d9c47281c302e45cb55218","after":"adead6e16467dcbb935057e2861d393bcc8bd1a2","ref":"refs/heads/scos-mitigations","pushedAt":"2024-07-05T16:26:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Fixes due to bump","shortMessageHtmlLink":"Fixes due to bump"}},{"before":"c9849c70f199698da0d6d84258d4727553876a76","after":"1bf976958ae4231ca0d9c47281c302e45cb55218","ref":"refs/heads/scos-mitigations","pushedAt":"2024-07-05T16:22:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Fixes due to bump","shortMessageHtmlLink":"Fixes due to bump"}},{"before":"62b3ab8b1425ad915e6e8cc9b8ad51061acde88c","after":"c9849c70f199698da0d6d84258d4727553876a76","ref":"refs/heads/scos-mitigations","pushedAt":"2024-07-05T15:45:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Remove the mitigations parameter in SCOS installations to force kernel defaults\n\nCurrently, OKD/SCOS is installed using FCOS boot images. FCOS boot images override the default setting for the mitigations parameter, disabling SMT in Intel-based machines.\nThis leads the installation to fail with the default machine types in AWS.\nThis commit will add the KernelArguments stanza to the ignition for the master and worker nodes, in order to remove the kernel parameter mitigations=auto,nosmt.","shortMessageHtmlLink":"Remove the mitigations parameter in SCOS installations to force kerne…"}},{"before":"88c164dd164c1b266b6172a0320a5a8170bb46ae","after":"62b3ab8b1425ad915e6e8cc9b8ad51061acde88c","ref":"refs/heads/scos-mitigations","pushedAt":"2024-07-05T15:41:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Remove mitigations in SCOS","shortMessageHtmlLink":"Remove mitigations in SCOS"}},{"before":null,"after":"88c164dd164c1b266b6172a0320a5a8170bb46ae","ref":"refs/heads/scos-mitigations","pushedAt":"2024-07-05T14:26:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Remove mitigations in SCOS","shortMessageHtmlLink":"Remove mitigations in SCOS"}},{"before":"331ad46fd517a4a97847188ede8af798ea8498c3","after":"d2b1a369a45595667b4b4d947e7db63facc0eecf","ref":"refs/heads/okd-fcos-agent","pushedAt":"2023-11-30T08:17:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"test","shortMessageHtmlLink":"test"}},{"before":"fa4927fb5273ac59044d40806275d080bf2955c8","after":"331ad46fd517a4a97847188ede8af798ea8498c3","ref":"refs/heads/okd-fcos-agent","pushedAt":"2023-11-30T06:53:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"test","shortMessageHtmlLink":"test"}},{"before":"f2a59fcfdc1c5df1adce430714439290b3df8dd6","after":"fa4927fb5273ac59044d40806275d080bf2955c8","ref":"refs/heads/okd-fcos-agent","pushedAt":"2023-11-30T06:46:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"test","shortMessageHtmlLink":"test"}},{"before":"2522a01766de517647a7d368f5442ae1a981d4c6","after":"f2a59fcfdc1c5df1adce430714439290b3df8dd6","ref":"refs/heads/okd-fcos-agent","pushedAt":"2023-11-29T16:47:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"OCPBUGS-19303: Changed OKD/FCOS workaround to also support Agent-based Installer\n\nOKD/FCOS uses FCOS as its bootimage, i.e. when booting cluster nodes\nthe first time during installation. FCOS does not provide tools such\nas OpenShift Client (oc) or crio.service which Agent-based Installer\nuses at the rendezvous host, e.g. to launch the bootstrap control\nplane.\n\nRHCOS and SCOS include these tools, but FCOS has to pivot the root fs\n[1] to okd-machine-os [2] first in order to make those tools available.\n\nPivoting uses 'rpm-ostree rebase' but the rendezvous host is booted\nthe first time the node boots from a FCOS Live ISO where the root fs\nand /sysroot are mounted read-only. Thus 'rpm-ostree rebase' fails and\nnecessary tools will not be available, causing the setup to stall.\n\nUntil rpm-ostree has implemented support for rebasing Live ISOs [3],\nthis patch adapts the workaround for SNO installations [4] to also\nsupport Agent-based Installer.\n\nIn particular, the Go conditional {{- if .BootstrapInPlace }} which\nis used to mark a SNO install has been replaced with a shell if-else\nwhich checks at runtime whether the system is launched from are on a\nLive ISO.\nMost code in the OpenShift ecosystem is written with RHCOS in mind\nand often assumes that tools like oc or crio.service are available.\nThese assumptions can be satisfied by applying this workaround to all\nLive ISO boots. It will not remove functionality or overwrite\nconfiguration files in /etc and thus side effects should be minimal.\n\nThe Go conditional {{- if .BootstrapInPlace }} in the release-image-\\\npivot.service has been dropped completely. This service is only used\nin OKD only, so OCP will not be impacted at all. The 'Before=' option\nwill not cause systemd to fail if a service does not exist. So, in\ncase bootkube.service or kubelet.service do not exist, the option will\nhave no effect.\nWhen bootkube.service or kubelet.service do exist, it must always be\nensured that release-image-pivot.service is started first because it\nmight reboot the system or change /usr in the Live ISO use case.\nSo it is safe to drop the Go conditional and ask systemd to always\nlaunch release-image-pivot.service before bootkube.service and\nkubelet.service.\n\n[0] https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template\n[1] https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootstrap-pivot.sh.template\n[2] https://github.com/openshift/okd-machine-os\n[3] https://github.com/coreos/rpm-ostree/issues/4547\n[4] https://github.com/openshift/installer/pull/7445","shortMessageHtmlLink":"OCPBUGS-19303: Changed OKD/FCOS workaround to also support Agent-base…"}},{"before":null,"after":"2522a01766de517647a7d368f5442ae1a981d4c6","ref":"refs/heads/okd-fcos-agent","pushedAt":"2023-11-28T04:20:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"OCPBUGS-19303: Changed OKD/FCOS workaround to also support Agent-based Installer\n\nOKD/FCOS uses FCOS as its bootimage, i.e. when booting cluster nodes\nthe first time during installation. FCOS does not provide tools such\nas OpenShift Client (oc) or crio.service which Agent-based Installer\nuses at the rendezvous host, e.g. to launch the bootstrap control\nplane.\n\nRHCOS and SCOS include these tools, but FCOS has to pivot the root fs\n[1] to okd-machine-os [2] first in order to make those tools available.\n\nPivoting uses 'rpm-ostree rebase' but the rendezvous host is booted\nthe first time the node boots from a FCOS Live ISO where the root fs\nand /sysroot are mounted read-only. Thus 'rpm-ostree rebase' fails and\nnecessary tools will not be available, causing the setup to stall.\n\nUntil rpm-ostree has implemented support for rebasing Live ISOs [3],\nthis patch adapts the workaround for SNO installations [4] to also\nsupport Agent-based Installer.\n\nIn particular, the Go conditional {{- if .BootstrapInPlace }} which\nis used to mark a SNO install has been replaced with a shell if-else\nwhich checks at runtime whether the system is launched from are on a\nLive ISO.\nMost code in the OpenShift ecosystem is written with RHCOS in mind\nand often assumes that tools like oc or crio.service are available.\nThese assumptions can be satisfied by applying this workaround to all\nLive ISO boots. It will not remove functionality or overwrite\nconfiguration files in /etc and thus side effects should be minimal.\n\nThe Go conditional {{- if .BootstrapInPlace }} in the release-image-\\\npivot.service has been dropped completely. This service is only used\nin OKD only, so OCP will not be impacted at all. The 'Before=' option\nwill not cause systemd to fail if a service does not exist. So, in\ncase bootkube.service or kubelet.service do not exist, the option will\nhave no effect.\nWhen bootkube.service or kubelet.service do exist, it must always be\nensured that release-image-pivot.service is started first because it\nmight reboot the system or change /usr in the Live ISO use case.\nSo it is safe to drop the Go conditional and ask systemd to always\nlaunch release-image-pivot.service before bootkube.service and\nkubelet.service.\n\n[0] https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template\n[1] https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootstrap-pivot.sh.template\n[2] https://github.com/openshift/okd-machine-os\n[3] https://github.com/coreos/rpm-ostree/issues/4547\n[4] https://github.com/openshift/installer/pull/7445","shortMessageHtmlLink":"OCPBUGS-19303: Changed OKD/FCOS workaround to also support Agent-base…"}},{"before":"69e391e74d83a4acdb0468bcab397579f1b1104b","after":"3e8ec6783ddbbbb8f095d81d237204408f557fe9","ref":"refs/heads/upi-yq-v4","pushedAt":"2023-10-16T17:57:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Add yq-v4 to the upi-installer image for CI and copy yq3 from a previous stage's manifest-list image\n\nWhile new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.\nMoreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.","shortMessageHtmlLink":"Add yq-v4 to the upi-installer image for CI and copy yq3 from a previ…"}},{"before":"9ab1bf5a4c7db75fa841f965361ce2ad2b3141fd","after":"69e391e74d83a4acdb0468bcab397579f1b1104b","ref":"refs/heads/upi-yq-v4","pushedAt":"2023-10-10T15:38:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Add yq-v4 to the upi-installer image for CI and copy yq3 from a previous stage's manifest-list image\n\nWhile new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.\nMoreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.","shortMessageHtmlLink":"Add yq-v4 to the upi-installer image for CI and copy yq3 from a previ…"}},{"before":"7738ab90388668f0fbd65d61133fc8d78c858f53","after":"9ab1bf5a4c7db75fa841f965361ce2ad2b3141fd","ref":"refs/heads/upi-yq-v4","pushedAt":"2023-10-10T15:32:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Add yq-v4 to the upi-installer image for CI and copy yq3 from a previous stage's manifest-list image\n\nWhile new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.\nMoreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.","shortMessageHtmlLink":"Add yq-v4 to the upi-installer image for CI and copy yq3 from a previ…"}},{"before":"7728a0db1e441be72f2c46cc33d88bdcf4f8e134","after":"7738ab90388668f0fbd65d61133fc8d78c858f53","ref":"refs/heads/upi-yq-v4","pushedAt":"2023-10-10T09:57:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Add yq-v4 to the upi-installer image for CI\n\nWhile new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit adds a layer to download and install yq-v4 in the upi-installer image.\nMoreover, let the yq-v3 and yq-v4 be downloaded for arm64 if we build the image on arm64.","shortMessageHtmlLink":"Add yq-v4 to the upi-installer image for CI"}},{"before":null,"after":"7728a0db1e441be72f2c46cc33d88bdcf4f8e134","ref":"refs/heads/upi-yq-v4","pushedAt":"2023-10-10T09:56:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aleskandro","name":"Alessandro Di Stefano","path":"/aleskandro","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13661032?s=80&v=4"},"commit":{"message":"Add yq-v4 to the upi-installer image for CI\n\nWhile new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit adds a layer to download and install yq-v4 in the upi-installer image.\nMoreover, let the yq-v3 and yq-v4 be downloaded for arm64 if we build the image on arm64.","shortMessageHtmlLink":"Add yq-v4 to the upi-installer image for CI"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEd_mhfQA","startCursor":null,"endCursor":null}},"title":"Activity · aleskandro/installer"}