Support serial data types. #135

suhaibaffan · 2020-07-03T05:23:18Z

Closes #96
Please give your input @alex-dukhno!

alex-dukhno

Thanks for PR. I think instead of introducing new enum variants we can extend existing SmallInt, Integer and BigInt. So you should have like:

SqlType::SmallInt(min),
SqlType::Integer(min),
SqlType::BigInt(min),

and also extend respective *TypeConstraint and you need to update sql_engine so that when user creates table with smallint type then we create SqlType::SmallInt(u16::MIN_VALUE) but if with smallserialthen SqlType::SmallInt(1).

it is actually what PostgreSQL does.

postgres=# create table serials(col1 smallserial);
postgres=# \d serials
                              Table "public.serials"
 Column |   Type   | Collation | Nullable |                Default
--------+----------+-----------+----------+---------------------------------------
 col1   | smallint |           | not null | nextval('serials_col1_seq'::regclass)

suhaibaffan · 2020-07-03T21:15:41Z

Got it, thanks @alex-dukhno.

suhaibaffan · 2020-07-05T05:04:16Z

@alex-dukhno let me know if I am on the right direction or not?

alex-dukhno

Looks good to me. Only minor comments. To fix rustfmt complaints you can run cargo +nightly fmt

alex-dukhno · 2020-07-06T06:44:26Z

src/sql_types/src/lib.rs

-            Ok(_) => Ok(()),
-            Err(e) if e.code == lexical::ErrorCode::InvalidDigit => Err(ConstraintError::NotAnInt),
-            Err(_) => Err(ConstraintError::OutOfRange),
+        if self.min < lexical::parse::<u16, _>(in_value).unwrap() {


Could you please move if check inside Ok(parsed) branch, unwraping will panic and in_value will be parsed only once

Sure, thanks.

alex-dukhno · 2020-07-06T06:44:59Z

src/sql_types/src/lib.rs

-            Ok(_) => Ok(()),
-            Err(e) if e.code == lexical::ErrorCode::InvalidDigit => Err(ConstraintError::NotAnInt),
-            Err(_) => Err(ConstraintError::OutOfRange),
+        if self.min < lexical::parse::<u32, _>(in_value).unwrap() {


same as above

alex-dukhno · 2020-07-06T06:45:06Z

src/sql_types/src/lib.rs

-            Err(e) if e.code == lexical::ErrorCode::InvalidDigit => Err(ConstraintError::NotAnInt),
-            Err(_) => Err(ConstraintError::OutOfRange),
+        if self.min < lexical::parse::<u64, _>(in_value).unwrap() {
+            match lexical::parse::<u64, _>(in_value) {


same as above

alex-dukhno · 2020-07-06T08:53:27Z

You can check clippy errors with ./ci/clippy-local.sh
cargo test --lib --all - unit tests and
pytest -v tests/functional/* - functional end-to-end tests

suhaibaffan · 2020-07-06T09:49:35Z

@alex-dukhno In sql_engine/src/ddl/create_table,
sqlparser::ast::DataType::Regclass => SqlType::Integer(1), I can use Regclass for just Serial, what do you suggest for smallSerial and bigSerial?

alex-dukhno · 2020-07-06T10:05:47Z

I am not sure about Regclass ... I bet that Custom(ObjectName) is what you are looking for https://github.com/ballista-compute/sqlparser-rs/blob/main/src/ast/data_type.rs#L67
But I can be wrong 😄

alex-dukhno · 2020-07-08T16:12:01Z

src/sql_engine/src/ddl/create_table.rs

                        sqlparser::ast::DataType::Char(len) => SqlType::Char(len.unwrap_or(255)),
                        sqlparser::ast::DataType::Varchar(len) => SqlType::VarChar(len.unwrap_or(255)),
                        sqlparser::ast::DataType::Boolean => SqlType::Bool,
+                        sqlparser::ast::DataType::Custom(ObjectName(_serial)) => SqlType::Integer(1),


Suggested change

sqlparser::ast::DataType::Custom(ObjectName(_serial)) => SqlType::Integer(1),

sqlparser::ast::DataType::Custom(name) => {

let name = name.to_string();

if name == "smallserial" {

SqlType::SmallInt(1);

} else if name == "serial" {

SqlType::Integer(1);

} else if name == "bigserial" {

SqlType::BigInt(1);

} else {

unimplemented!("{:?} type is not supported", name)

}

},

this should help

Thanks @alex-dukhno fixed, please review it.

alex-dukhno · 2020-07-08T17:19:43Z

I'll merge it as I am currently working on type improvements

alex-dukhno · 2020-07-08T17:20:01Z

Thanks for the PR

suhaibaffan force-pushed the Support-serial-data-types-#96 branch 2 times, most recently from d2e2ef5 to 4b277b8 Compare July 3, 2020 06:22

alex-dukhno reviewed Jul 3, 2020

View reviewed changes

suhaibaffan force-pushed the Support-serial-data-types-#96 branch 3 times, most recently from d0eff35 to 40959d7 Compare July 6, 2020 02:55

alex-dukhno reviewed Jul 6, 2020

View reviewed changes

suhaibaffan force-pushed the Support-serial-data-types-#96 branch from 19aa9ed to 49be91c Compare July 6, 2020 08:44

suhaibaffan force-pushed the Support-serial-data-types-#96 branch from 783e1b8 to 841ab2e Compare July 7, 2020 10:41

suhaibaffan added 8 commits July 8, 2020 20:47

Support serial data types.

ec80070

Extended smallInt, Integer and BigInt to support serial types.

c14ed83

Updated with the latest code.

0544ce9

Fixed fmt errors.

79b354a

Updated integer types in create tables.

d0f9dce

Removed unsigned types.

499619d

Fixed fmt.

e2072f0

Added min value in the int test cases.

5684300

suhaibaffan force-pushed the Support-serial-data-types-#96 branch from 2e70ca0 to 1a24746 Compare July 8, 2020 15:31

Used custom type for serial, bigserial and smallserial

c9fea1d

suhaibaffan force-pushed the Support-serial-data-types-#96 branch from 1a24746 to c9fea1d Compare July 8, 2020 15:35

alex-dukhno reviewed Jul 8, 2020

View reviewed changes

Fixed unreachable pattern error.

0323093

suhaibaffan force-pushed the Support-serial-data-types-#96 branch from d1927b6 to 0323093 Compare July 8, 2020 17:08

alex-dukhno approved these changes Jul 8, 2020

View reviewed changes

alex-dukhno merged commit 78bfd26 into alex-dukhno:master Jul 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support serial data types. #135

Support serial data types. #135

suhaibaffan commented Jul 3, 2020 •

edited by alex-dukhno

Loading

alex-dukhno left a comment

suhaibaffan commented Jul 3, 2020

suhaibaffan commented Jul 5, 2020

alex-dukhno left a comment

alex-dukhno Jul 6, 2020

suhaibaffan Jul 6, 2020

alex-dukhno Jul 6, 2020

alex-dukhno Jul 6, 2020

alex-dukhno commented Jul 6, 2020

suhaibaffan commented Jul 6, 2020

alex-dukhno commented Jul 6, 2020

alex-dukhno Jul 8, 2020

alex-dukhno Jul 8, 2020

suhaibaffan Jul 8, 2020

alex-dukhno commented Jul 8, 2020

alex-dukhno commented Jul 8, 2020

-                        sqlparser::ast::DataType::Custom(ObjectName(_serial)) => SqlType::Integer(1),
+                        sqlparser::ast::DataType::Custom(name) => {
+                            let name = name.to_string();
+                            if name == "smallserial" {
+                                SqlType::SmallInt(1);
+                            } else if name == "serial" {
+                                SqlType::Integer(1);
+                            } else if name == "bigserial" {
+                                SqlType::BigInt(1);
+                            } else {
+                                unimplemented!("{:?} type is not supported", name)
+                            }
+                        },

Support serial data types. #135

Support serial data types. #135

Conversation

suhaibaffan commented Jul 3, 2020 • edited by alex-dukhno Loading

alex-dukhno left a comment

Choose a reason for hiding this comment

suhaibaffan commented Jul 3, 2020

suhaibaffan commented Jul 5, 2020

alex-dukhno left a comment

Choose a reason for hiding this comment

alex-dukhno Jul 6, 2020

Choose a reason for hiding this comment

suhaibaffan Jul 6, 2020

Choose a reason for hiding this comment

alex-dukhno Jul 6, 2020

Choose a reason for hiding this comment

alex-dukhno Jul 6, 2020

Choose a reason for hiding this comment

alex-dukhno commented Jul 6, 2020

suhaibaffan commented Jul 6, 2020

alex-dukhno commented Jul 6, 2020

alex-dukhno Jul 8, 2020

Choose a reason for hiding this comment

alex-dukhno Jul 8, 2020

Choose a reason for hiding this comment

suhaibaffan Jul 8, 2020

Choose a reason for hiding this comment

alex-dukhno commented Jul 8, 2020

alex-dukhno commented Jul 8, 2020

suhaibaffan commented Jul 3, 2020 •

edited by alex-dukhno

Loading