Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-reanimated v3 drops support for code this package uses (fixed) #94

Open
Ario99 opened this issue Jan 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Ario99
Copy link

Ario99 commented Jan 23, 2024

Describe the bug
react-native-reanimated dropped support for api v1 which this repo depended on. The fix I have provided is a modification of @phanghos's code in their issue for the nonexpo version of this package. I have patched this issue with patch-package for v1.0.28. I used this patch and some resolutions to fix the issue for myself.

Patch

Resolutions

  • "react-native-reanimated": "~3.3.0"
  • "expo-linear-gradient": "~12.3.0"
  • "react-native-redash": "^18.1.0

Here is the diff that fixed this problem for me
react-native-skeleton-content+1.0.28.patch

To Reproduce
You will run into the same problem upon upgrading to a newer version of the expo sdk. I am running this currently on expo sdk 49.

Expected behavior
Animations to play where they were previously working.

Smartphone (please complete the following information):

  • Device: SM-G991U1 (Galaxy S21 5G)
  • OS: Android v13, One UI v5.1
  • Package version: 1.0.28

Additional context
I understand that this issue may not be fixed with the info I provided for an indefinite period of time. The maintainer is predisposed so in the mean time I hope I have provided the information others may need so they will not have to jump through the same hoops I did. I definitely did learn a lot in the process. If you have any questions, I hope I will be able to answer in a timely matter.

Also it seems if you don't want to mess with patch-package to fix this. You may be able to use this package in the mean time until the pull request for the changes contained within @marcuzgabriel's are made. I'm not for sure if I tried their package previously but it may be more convenient for you than what I have given here.

@Ario99 Ario99 added the bug Something isn't working label Jan 23, 2024
@AnushavanGhulyan-melon
Copy link

This is the updated version.
https://github.com/marcuzgabriel/react-native-reanimated-skeleton

@Engazan
Copy link

Engazan commented Feb 13, 2024

This is the updated version. https://github.com/marcuzgabriel/react-native-reanimated-skeleton

nah, its not for expo, it uses react-native-linear-gradient ... and not expo-linear-gradient ...

@marcuzgabriel
Copy link

@Engazan. Isn't it possible to switch out expo-linear-gradient package with react-native-linear-gradient or does expo not support that?

@Engazan
Copy link

Engazan commented Feb 13, 2024

@Engazan. Isn't it possible to switch out expo-linear-gradient package with react-native-linear-gradient or does expo not support that?

I m not sure but it contains iOS and android folders witch almost always mesn that you need "config plugin" / prebuild (dev client) or eject (almost useless nowdays)

But when i tried it i got errors With can be solved only With "pod install" or config plugin :/

But for this project i cant do that, client doesnt want that

But there is "react-native-shimmer-placeholder" that works fine With expo and it only need minimum changes its almost same kind of, and it has driber option so you can choose what you want use (expo or something else ) witch is great

@marcuzgabriel
Copy link

Good you found an alternative 🥇 . I will try have a look on why react-native-linear-gradient won't work with expo and the other way around why expo-linear-gradient won't work with my library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants