The pirateweather integration is using deprecated forecast (2023.9.0b0)

[TheFes]

HA will remove the forecast attribute, you will have to move to a new method to include the forecast

see https://developers.home-assistant.io/blog/2023/08/07/weather_entity_forecast_types/

[alexander0042]

Thanks for the heads up here! I've had my eye on the changes to the source, so great to see everything documented. The current approach leaves much to be desired, and so I'm really happy with these new updates

[Intecpsp]

Any update here now that this is GA?

[tcfurrer]

@Intecpsp it's only a warning for now, and won't be a real problem until March 2024 (if I understand correctly). I assume @alexander0042 will prioritize/schedule this issue to be fixed in a new release some time before then.

Attaching a screenshot of the message I got about this on my HA instance.

[dmbreakey]

Apologies for the repeat, but I mentioned this on #137 but it doesn't seem like that's been noticed, so adding it here.

You might be interested to know that AstroWeather recently updated their integration to support the new service mode.

[TheFes]

Just a request, please leave the forecasts in until 2024.3 like the core integrations do as well.
Another custom weather integration removed it already, and I still rely on the forecast attribute for a template weather entity.

[Chaotic]

Any update on this? Been a few months at this point since the change went live.

[alexander0042]

Apologies for the radio silence, but I've got good news here! I'm going to post a longer update as a project, but in short, I have a immediate solution to this specific issue that should address this. It keeps 95% of the same code and structure, with a little translation layer to fit it into the new Home Assistant format. I'm going to leave it running on my machine for a couple days to make sure it's working, but then I'll push it out as an update!

In the process of fixing this, I ended up spending a fair bit of time thinking about the underlying structure, and I think that it makes the most sense to restructure the integration using all the new tools. Going to push this as a branch, so will be available for discussion but won't come out as an update. This should fix the occasional update issue, remove the legacy Dark Sky dependency, and allow for it to eventually make it into the default. However, it will likely break compatibility with the existing integration, hence the fix to this one first!

[TheFes]

Will you include the forecast attribute until 2024.3 or will you immediately remove it?

[cloneofghosts]

Apologies for the radio silence, but I've got good news here! I'm going to post a longer update as a project, but in short, I have a immediate solution to this specific issue that should address this. It keeps 95% of the same code and structure, with a little translation layer to fit it into the new Home Assistant format. I'm going to leave it running on my machine for a couple days to make sure it's working, but then I'll push it out as an update!

In the process of fixing this, I ended up spending a fair bit of time thinking about the underlying structure, and I think that it makes the most sense to restructure the integration using all the new tools. Going to push this as a branch, so will be available for discussion but won't come out as an update. This should fix the occasional update issue, remove the legacy Dark Sky dependency, and allow for it to eventually make it into the default. However, it will likely break compatibility with the existing integration, hence the fix to this one first!

You could always publish both the immediate and long term fixes as branches on the project and release beta versions for people to try as you can download beta versions in HACS. Could always be helpful for the immediate fix to test on other setups besides your own.

[alexander0042]

@TheFes, the plan is to keep this repo around so long as there's no major incompatibility within Home Assistant that makes it impossible. The key reason to transition to a new codebase to get added to the built in HA install is because of the YAML support. I want to keep this one compatible with legacy yaml, but that really isn't possible in order to be added as a new HA integration.

@cloneofghosts, love this plan, and is exactly what I'm planning on doing. You'll see a "beta" tag today that is the existing integration with this fix, along with a (broken) "future" branch that I'll use to put together a fully HA compliant version going forward.

[alexander0042]

OK, and pre-release is live! Looks like anyone using HACS should see it if they enabled "show pre-release" when it was installed, otherwise you need to remove and re-add the Pirate Weather repo in HACS

[mermelmadness]

OK, and pre-release is live! Looks like anyone using HACS should see it if they enabled "show pre-release" when it was installed, otherwise you need to remove and re-add the Pirate Weather repo in HACS

Great. I'll check it out shortly. I integrate Pirate Weather forecast attribute data into a lot of my stuff, including this LED Matrix information panel, so I'll let you know how things integrate with the update.

[cloneofghosts]

Outside of the time sensor issue everything has been running smoothly on my end. Just wanted to note that if you're using a custom weather card it might not work correctly with the update. They'll need to update the card on their end to support the forecast attribute otherwise it won't work correctly

Maybe it's something that @alexander0042 could mention in the release notes or the repositories readme file.

[cloneofghosts]

@alexander0042 This is ready for a public release no? Haven't seen any new issues pop up since the time parameter issue was fixed on the 15th. I have the ability to create/edit releases so I can make the most recent pre-release the latest release version if you'd like.

[alexander0042]

Now that I've tested the version control (which would have been bad), I agree we're ready to push to main, and would appreciate if you could do that! I just pushed a new commit reverting my testing changes, so I think you'll have to make a new tag and mark that one as the official release

[cloneofghosts]

Stable version released. Thank you to everyone who tested the pre-release version.