Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable zabbix value mapping translation in query. #1128

Closed
serg-ku opened this issue Dec 30, 2020 · 9 comments
Closed

Add option to disable zabbix value mapping translation in query. #1128

serg-ku opened this issue Dec 30, 2020 · 9 comments

Comments

@serg-ku
Copy link

serg-ku commented Dec 30, 2020

In 4.1 release Grafana-Zabbix started to use zabbix value mappings, but this breaks old dashboards where mapping are configured in grafana and also in zabbix, because zabbix mappings takes priority.

I think best solution will be an option to disable zabbix value mapping translation on query basis, option to disable it in datasource will also fix this, but It's not flexible enough, also selectable priority (search in grafana and if not found in zabbix mapping) can do the job, but I don't know if it's possible to implement.

Also value mappings in zabbix can be descriptive and long, but in Grafana you want to use simple OK and ALARM mappings, for example for persons on duty, only to indicate problem and long descriptions from zabbix mappings can be unreadable and useless on dashboard.

@mr-ns
Copy link
Contributor

mr-ns commented Jan 6, 2021

+100!!!
This breaks many, many existing dashboards; we definitely need a way to disable this globally (datasource config) with perhaps a per-query setting.

@serg-ku
Copy link
Author

serg-ku commented Jan 6, 2021

Totally disabling isn't a good choice. You won't be able to use it in other dashboards, maybe something like "Disable by default" and enable per-query, or disable/enable by default for dashboard and enable/disable per-query

@mr-ns
Copy link
Contributor

mr-ns commented Jan 6, 2021

Agree. There should be a global or "default" setting in the plugin config, which can then be overridden at the query level if so desired.

@isaqueprofeta
Copy link

isaqueprofeta commented Feb 3, 2021

@alexanderzobnin this one is pretty high priority, The default that most users do, is to get the data from zabbix raw and use units in Grafana.

Even more, it brokes the usage of thresholds, because we need to get the raw integers in a lot of cases, since thresholds do not support text as a limit parameter.

I got myself more than 50 broken dashboards if update.

@alexanderzobnin
Copy link
Collaborator

I agree, in many cases it breaks user experience. So I'll add switch to the query editor to enable this option, it will be disabled by default.

@serg-ku
Copy link
Author

serg-ku commented Feb 8, 2021

@alexanderzobnin will this fix also affect #1130 ?

@alexanderzobnin
Copy link
Collaborator

@serg-ku this only affects value mapping.

@serg-ku
Copy link
Author

serg-ku commented Feb 15, 2021

@alexanderzobnin is there any fix planned for #1130 or it's not used by anyone?) It's standard grafana functionality)

@isaqueprofeta
Copy link

Keep issue discussion the the right related issue please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants