Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Library request in cdnjs #64

Open
extend1994 opened this issue Nov 29, 2016 · 7 comments
Open

Library request in cdnjs #64

extend1994 opened this issue Nov 29, 2016 · 7 comments

Comments

@extend1994
Copy link

extend1994 commented Nov 29, 2016

Hi,
There is a library request in cdnjs.
To contain the library correctly, I would like to check the files needed to be added.

The files I plan to add is:
all files in /src ( including /src/utils and /src/themes )

Are they complete for users? Or other files required? Or some files not required?

Thank you for your great work!

@alexkuz
Copy link
Owner

alexkuz commented Nov 30, 2016

I'm not sure how exactly it should work, I'm not that familiar with cdnjs. Shouldn't it be a prebuilt bundle?
Otherwise - yes, /src contains everything required.

@extend1994
Copy link
Author

extend1994 commented Dec 4, 2016

cdnjs contains files running on browsers.
So whether files in format like JSON___Node.js in /src may be for nodejs only but not the browsers?
If there are other files not required, please tell me.

Thank you for your reponse :)

@alexkuz
Copy link
Owner

alexkuz commented Dec 5, 2016

cdnjs contains files running on browsers.

Yeah, I get that, but I'm not sure how it will should be built to work with external React etc.
All files are required, it just supposed to be built with a bundler like webpack or browserify.
I think you can use a config to build it like this one:

https://github.com/christianalfoni/formsy-react/blob/master/webpack.production.config.js

@PeterDaveHello
Copy link

All files are required, it just supposed to be built with a bundler like webpack or browserify.

Agree, sometimes we just got library hosting request from users don't really know how the libs work, I'm not writing react apps, but I also wonder if this host could help, or is this the proper way to host it.

@alexkuz if you are also not sure, and not going to provide pre-bundled dist files, I think maybe we should just leave it alone, until we know about how to handle it, what do you think?

@alexkuz
Copy link
Owner

alexkuz commented Dec 22, 2016

True. It's probably not hard to build that dist (and there are probably other react libs in cdnjs already, just like that formsy-react), but I don't have much time to dig in it right now.

@PeterDaveHello
Copy link

Maybe we could just leave this issue open for a while, and close it if we can't make it after months, thanks @alexkuz

@alexkuz
Copy link
Owner

alexkuz commented Dec 23, 2016

Yep, that's fine for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants