Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module context scripts look for the wrong attribute #72

Closed
ekhaled opened this issue Aug 26, 2021 · 0 comments · Fixed by #73
Closed

Module context scripts look for the wrong attribute #72

ekhaled opened this issue Aug 26, 2021 · 0 comments · Fixed by #73
Labels
bug Something isn't working
Milestone
4.0.0

Comments

@ekhaled
Copy link
Contributor

ekhaled commented Aug 26, 2021

According to Svelte docs module scripts are to be marked with context="module".

Instead we look for scope="module".

This is incorrect, and therefore does not mark static variables and methods properly when <script context="module"> is used.
@ekhaled ekhaled mentioned this issue Aug 26, 2021
Merged
@alexprey alexprey added the bug Something isn't working label Aug 27, 2021
@alexprey alexprey added this to the 4.0.0 milestone Aug 27, 2021
alexprey added a commit that referenced this issue Aug 27, 2021
@alexprey
Merge pull request #73 from ekhaled/module-scope-correction
2472b5a 
fix #72: Use of "context" instead of "scope" when parsing module scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

fix #72: Use of "context" instead of "scope" when parsing module scripts ekhaled/sveltedoc-parser
2 participants
@ekhaled @alexprey