[Feature] Realtime API from OpenAI working #545
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franpb14
commented
Nov 4, 2024
| end | ||
|
|
||
| def connect(model: "gpt-4o-realtime-preview-2024-10-01") | ||
| uri = "#{File.join(@client.websocket_uri_base, @client.api_version, 'realtime')}?model=#{model}" |
There was a problem hiding this comment.
probably this uri shouldn't be here but I was not sure where to put it
|
Is it out of scope to add a sample sinatra app into the repo with some stimulusjs that demos the client-side setup of the websocket/connection to feed/receive messages to the backend? |
franpb14
commented
Dec 9, 2024
Comment on lines
+21
to
+24
| EM.run do | ||
| @websocket = Faye::WebSocket::Client.new(uri, nil, headers: openai_realtime_headers) | ||
| @websocket.on :message, @on_message | ||
| end |
There was a problem hiding this comment.
Perhaps we should replace Eventmachine since it last release was 6 yeas ago. I think we could use async. I have tried and it works fine with something like this:
Async do
endpoint = Async::HTTP::Endpoint.parse(uri, alpn_protocols: Async::HTTP::Protocol::HTTP11.names)
Async::WebSocket::Client.connect(endpoint, headers: @headers) do |connection|
@websocket = connection
while (message = connection.read)
@on_message
end
end
end
|
@drnic Sorry the delay in the answer, I think it'd be a good thing to have, for me it was the hardest part. If we finally merge this I could do that app easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This is a very basic PR that we can use to iterate. Right now I'm using it with ActionCable in a rails app like this:
In the example
data['event']can be something like this:Maybe we could add more functions in order to facilitate event management. Something like I said in this comment.
Dependencies
faye-websocketeventmachineAll Submissions:
Closes #524