Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

PardallMarkdown.FileParser.parse!/1 should actually crash and interrupt content reloading in case of error #46

Open
alfredbaudisch opened this issue Sep 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@alfredbaudisch
Copy link
Owner

Right now, there's no reason to call parse! (with !) since it doesn't throw an exception in case of error (this actually comes from the early prototype).

If there's an error when parsing a Markdown file, the error is logged and other files are still parsed and the Repository still reloads all of the content. This leads to unwanted results, such as broken hierarchies (because the files that error'ed were ignored by the parser).

Instead, crash and interrupt content reloading, keeping the existing content as the current version. Or at least, make this a configuration.

@alfredbaudisch alfredbaudisch added the enhancement New feature or request label Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant