From 88db99e5de882f6e4c0b557d2db3cf99ee5005b2 Mon Sep 17 00:00:00 2001
From: ederc <ederc@mathematik.uni-kl.de>
Date: Fri, 27 Sep 2024 21:15:15 +0200
Subject: [PATCH 1/3] introduces documentation for dimension

---
 docs/make.jl                | 1 +
 src/algorithms/dimension.jl | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/make.jl b/docs/make.jl
index ab996ee..b8754eb 100644
--- a/docs/make.jl
+++ b/docs/make.jl
@@ -21,6 +21,7 @@ makedocs(
         "types.md",
         "Algorithms" => ["groebner-bases.md",
                          "normal-forms.md",
+                         "dimension.md",
                          "solvers.md"],
         "Examples" => "katsura.md"
         ]
diff --git a/src/algorithms/dimension.jl b/src/algorithms/dimension.jl
index 5164a89..05ff7a4 100644
--- a/src/algorithms/dimension.jl
+++ b/src/algorithms/dimension.jl
@@ -3,7 +3,7 @@
 
 Compute the Krull dimension of a given polynomial ideal `I`.
 
-**Note**: This requires a Gröbner basis of `I`. 
+**Note**: This requires a Gröbner basis of `I`, which is computed internally if not alraedy known.
 
 # Examples
 ```jldoctest

From f93ac32a1b8097b155023615b4d9ae2afd07bb68 Mon Sep 17 00:00:00 2001
From: ederc <ederc@mathematik.uni-kl.de>
Date: Fri, 27 Sep 2024 21:16:08 +0200
Subject: [PATCH 2/3] prepares v0.7.1

---
 Project.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Project.toml b/Project.toml
index ecdc0ac..1e6976a 100644
--- a/Project.toml
+++ b/Project.toml
@@ -1,7 +1,7 @@
 name = "AlgebraicSolving"
 uuid = "66b61cbe-0446-4d5d-9090-1ff510639f9d"
 authors = ["ederc <ederc@mathematik.uni-kl.de>", "Mohab Safey El Din <Mohab.Safey@lip6.fr", "Rafael Mohr <rafael.mohr@lip6.fr>"]
-version = "0.7.0"
+version = "0.7.1"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

From 8784b05b94f3ba8b323abcbc129f9ae46183e04f Mon Sep 17 00:00:00 2001
From: ederc <ederc@mathematik.uni-kl.de>
Date: Fri, 27 Sep 2024 21:25:39 +0200
Subject: [PATCH 3/3] adds missing dimension md file

---
 docs/src/dimension.md | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 docs/src/dimension.md

diff --git a/docs/src/dimension.md b/docs/src/dimension.md
new file mode 100644
index 0000000..ce44f18
--- /dev/null
+++ b/docs/src/dimension.md
@@ -0,0 +1,31 @@
+```@meta
+CurrentModule = AlgebraicSolving
+DocTestSetup = quote
+  using AlgebraicSolving
+end
+```
+
+```@setup algebraicsolving
+using AlgebraicSolving
+```
+
+```@contents
+Pages = ["dimension.md"]
+```
+
+# Krull dimension of an ideal
+
+## Introduction
+
+AlgebraicSolving allows to compute the Krull dimension for the ideal spanned
+by given input generators over finite fields of characteristic smaller
+$2^{31}$ and over the rationals.
+
+The underlying engine is provided by msolve.
+
+## Functionality
+
+```@docs
+    dimension(I::Ideal{T}) where T <: MPolyRingElem
+```
+