fix(query rules): Suppress rule condition pattern marshalling in case…

… of empty anchoring (#689)
algolia · Aug 29, 2022 · dce3e44 · dce3e44
1 parent 3e8fd6d
commit dce3e44
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/algolia/search/rule_condition.go b/algolia/search/rule_condition.go
@@ -12,7 +12,7 @@ type RuleCondition struct {
 
 func (c RuleCondition) MarshalJSON() ([]byte, error) {
 	m := make(map[string]interface{})
-	if c.Anchoring != "" || c.Pattern != "" {
+	if c.Anchoring != "" {
 		m["anchoring"] = c.Anchoring
 		m["pattern"] = c.Pattern
 	}

diff --git a/algolia/search/rule_condition_test.go b/algolia/search/rule_condition_test.go
@@ -44,7 +44,7 @@ func TestRuleCondition_MarshalJSON(t *testing.T) {
 				Alternatives: nil,
 				Filters:      "",
 			},
-			`{"anchoring": "", "pattern": "Pattern"}`,
+			`{}`,
 		},
 		{
 			RuleCondition{
@@ -106,7 +106,11 @@ func TestRuleCondition_MarshalJSON(t *testing.T) {
 
 		// Compare the two RuleConditions
 		require.Equal(t, c.condition.Anchoring, condition.Anchoring)
-		require.Equal(t, c.condition.Pattern, condition.Pattern)
+		if c.condition.Anchoring == "" {
+			require.Equal(t, condition.Pattern, "")
+		} else {
+			require.Equal(t, c.condition.Pattern, condition.Pattern)
+		}
 		require.Equal(t, c.condition.Context, condition.Context)
 		if c.condition.Alternatives == nil {
 			require.Nil(t, condition.Alternatives)