From b728c5f258783da3693757d8a03368dbdc0b1a6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Vannicatte?= Date: Tue, 26 Nov 2024 13:50:30 +0100 Subject: [PATCH] fix(specs): `consequence` is required when saving rules (#4146) --- .github/workflows/check.yml | 2 +- .../package.json | 2 +- .../algoliasearch-client-javascript/yarn.lock | 340 ++++-------------- config/generation.config.mjs | 1 + playground/javascript/node/search.ts | 7 +- specs/search/paths/rules/common/schemas.yml | 1 + .../javascript/clients/rollup.config.mustache | 1 + tests/CTS/requests/search/saveRule.json | 14 +- tests/CTS/requests/search/saveRules.json | 28 +- yarn.lock | 111 ++++-- 10 files changed, 193 insertions(+), 314 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 6597f49b94..74b515db5e 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -41,7 +41,7 @@ jobs: runs-on: ubuntu-22.04 timeout-minutes: 10 env: - CACHE_VERSION: 1.12 # bump this to run all clients on the CI. + CACHE_VERSION: 1.13 # bump this to run all clients on the CI. steps: - name: debugging - dump GitHub context env: diff --git a/clients/algoliasearch-client-javascript/package.json b/clients/algoliasearch-client-javascript/package.json index bbedfebeeb..976fe3af3f 100644 --- a/clients/algoliasearch-client-javascript/package.json +++ b/clients/algoliasearch-client-javascript/package.json @@ -6,7 +6,7 @@ "packages/*" ], "scripts": { - "build": "lerna run build --scope '@algolia/requester-testing' --scope '@algolia/logger-console' --scope 'algoliasearch' --scope '@algolia/client-composition' --include-dependencies", + "build": "lerna run build --skip-nx-cache --scope '@algolia/requester-testing' --scope '@algolia/logger-console' --scope 'algoliasearch' --scope '@algolia/client-composition' --include-dependencies", "clean": "lerna run clean", "release:publish": "tsc --project scripts/tsconfig.json && node scripts/dist/publish.js", "test": "lerna run test $*", diff --git a/clients/algoliasearch-client-javascript/yarn.lock b/clients/algoliasearch-client-javascript/yarn.lock index d311248e94..ff34f7fe4e 100644 --- a/clients/algoliasearch-client-javascript/yarn.lock +++ b/clients/algoliasearch-client-javascript/yarn.lock @@ -1317,8 +1317,8 @@ __metadata: linkType: hard "@nx/devkit@npm:>=17.1.2 < 21": - version: 20.1.2 - resolution: "@nx/devkit@npm:20.1.2" + version: 20.1.3 + resolution: "@nx/devkit@npm:20.1.3" dependencies: ejs: "npm:^3.1.7" enquirer: "npm:~2.3.6" @@ -1330,76 +1330,76 @@ __metadata: yargs-parser: "npm:21.1.1" peerDependencies: nx: ">= 19 <= 21" - checksum: 10/6e7848bd83b166d38c1ac2cb78624ccfdad4f025917b8a5976286d491d44e35ec34123183e3f05be3a1b9f8399d860b342e435e4c5bb41a83c86e990a6dc19ce + checksum: 10/8cf591b18ee8b31deb0abad8d3f1da2a9462fc1cfc290200b72ad6792c5c01b272be234c03ca00abfd8490f4c7a1f40c177d368368f0b8deb1583dfe2a58aef2 languageName: node linkType: hard -"@nx/nx-darwin-arm64@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-darwin-arm64@npm:20.1.2" +"@nx/nx-darwin-arm64@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-darwin-arm64@npm:20.1.3" conditions: os=darwin & cpu=arm64 languageName: node linkType: hard -"@nx/nx-darwin-x64@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-darwin-x64@npm:20.1.2" +"@nx/nx-darwin-x64@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-darwin-x64@npm:20.1.3" conditions: os=darwin & cpu=x64 languageName: node linkType: hard -"@nx/nx-freebsd-x64@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-freebsd-x64@npm:20.1.2" +"@nx/nx-freebsd-x64@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-freebsd-x64@npm:20.1.3" conditions: os=freebsd & cpu=x64 languageName: node linkType: hard -"@nx/nx-linux-arm-gnueabihf@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-linux-arm-gnueabihf@npm:20.1.2" +"@nx/nx-linux-arm-gnueabihf@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-linux-arm-gnueabihf@npm:20.1.3" conditions: os=linux & cpu=arm languageName: node linkType: hard -"@nx/nx-linux-arm64-gnu@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-linux-arm64-gnu@npm:20.1.2" +"@nx/nx-linux-arm64-gnu@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-linux-arm64-gnu@npm:20.1.3" conditions: os=linux & cpu=arm64 & libc=glibc languageName: node linkType: hard -"@nx/nx-linux-arm64-musl@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-linux-arm64-musl@npm:20.1.2" +"@nx/nx-linux-arm64-musl@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-linux-arm64-musl@npm:20.1.3" conditions: os=linux & cpu=arm64 & libc=musl languageName: node linkType: hard -"@nx/nx-linux-x64-gnu@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-linux-x64-gnu@npm:20.1.2" +"@nx/nx-linux-x64-gnu@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-linux-x64-gnu@npm:20.1.3" conditions: os=linux & cpu=x64 & libc=glibc languageName: node linkType: hard -"@nx/nx-linux-x64-musl@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-linux-x64-musl@npm:20.1.2" +"@nx/nx-linux-x64-musl@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-linux-x64-musl@npm:20.1.3" conditions: os=linux & cpu=x64 & libc=musl languageName: node linkType: hard -"@nx/nx-win32-arm64-msvc@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-win32-arm64-msvc@npm:20.1.2" +"@nx/nx-win32-arm64-msvc@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-win32-arm64-msvc@npm:20.1.3" conditions: os=win32 & cpu=arm64 languageName: node linkType: hard -"@nx/nx-win32-x64-msvc@npm:20.1.2": - version: 20.1.2 - resolution: "@nx/nx-win32-x64-msvc@npm:20.1.2" +"@nx/nx-win32-x64-msvc@npm:20.1.3": + version: 20.1.3 + resolution: "@nx/nx-win32-x64-msvc@npm:20.1.3" conditions: os=win32 & cpu=x64 languageName: node linkType: hard @@ -1563,13 +1563,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-android-arm-eabi@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-android-arm-eabi@npm:4.27.3" - conditions: os=android & cpu=arm - languageName: node - linkType: hard - "@rollup/rollup-android-arm-eabi@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-android-arm-eabi@npm:4.27.4" @@ -1577,13 +1570,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-android-arm64@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-android-arm64@npm:4.27.3" - conditions: os=android & cpu=arm64 - languageName: node - linkType: hard - "@rollup/rollup-android-arm64@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-android-arm64@npm:4.27.4" @@ -1591,13 +1577,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-darwin-arm64@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-darwin-arm64@npm:4.27.3" - conditions: os=darwin & cpu=arm64 - languageName: node - linkType: hard - "@rollup/rollup-darwin-arm64@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-darwin-arm64@npm:4.27.4" @@ -1605,13 +1584,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-darwin-x64@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-darwin-x64@npm:4.27.3" - conditions: os=darwin & cpu=x64 - languageName: node - linkType: hard - "@rollup/rollup-darwin-x64@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-darwin-x64@npm:4.27.4" @@ -1619,13 +1591,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-freebsd-arm64@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-freebsd-arm64@npm:4.27.3" - conditions: os=freebsd & cpu=arm64 - languageName: node - linkType: hard - "@rollup/rollup-freebsd-arm64@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-freebsd-arm64@npm:4.27.4" @@ -1633,13 +1598,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-freebsd-x64@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-freebsd-x64@npm:4.27.3" - conditions: os=freebsd & cpu=x64 - languageName: node - linkType: hard - "@rollup/rollup-freebsd-x64@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-freebsd-x64@npm:4.27.4" @@ -1647,13 +1605,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-arm-gnueabihf@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-arm-gnueabihf@npm:4.27.3" - conditions: os=linux & cpu=arm & libc=glibc - languageName: node - linkType: hard - "@rollup/rollup-linux-arm-gnueabihf@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-arm-gnueabihf@npm:4.27.4" @@ -1661,13 +1612,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-arm-musleabihf@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-arm-musleabihf@npm:4.27.3" - conditions: os=linux & cpu=arm & libc=musl - languageName: node - linkType: hard - "@rollup/rollup-linux-arm-musleabihf@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-arm-musleabihf@npm:4.27.4" @@ -1675,13 +1619,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-arm64-gnu@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-arm64-gnu@npm:4.27.3" - conditions: os=linux & cpu=arm64 & libc=glibc - languageName: node - linkType: hard - "@rollup/rollup-linux-arm64-gnu@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-arm64-gnu@npm:4.27.4" @@ -1689,13 +1626,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-arm64-musl@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-arm64-musl@npm:4.27.3" - conditions: os=linux & cpu=arm64 & libc=musl - languageName: node - linkType: hard - "@rollup/rollup-linux-arm64-musl@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-arm64-musl@npm:4.27.4" @@ -1703,13 +1633,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-powerpc64le-gnu@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-powerpc64le-gnu@npm:4.27.3" - conditions: os=linux & cpu=ppc64 & libc=glibc - languageName: node - linkType: hard - "@rollup/rollup-linux-powerpc64le-gnu@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-powerpc64le-gnu@npm:4.27.4" @@ -1717,13 +1640,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-riscv64-gnu@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-riscv64-gnu@npm:4.27.3" - conditions: os=linux & cpu=riscv64 & libc=glibc - languageName: node - linkType: hard - "@rollup/rollup-linux-riscv64-gnu@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-riscv64-gnu@npm:4.27.4" @@ -1731,13 +1647,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-s390x-gnu@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-s390x-gnu@npm:4.27.3" - conditions: os=linux & cpu=s390x & libc=glibc - languageName: node - linkType: hard - "@rollup/rollup-linux-s390x-gnu@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-s390x-gnu@npm:4.27.4" @@ -1745,13 +1654,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-x64-gnu@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-x64-gnu@npm:4.27.3" - conditions: os=linux & cpu=x64 & libc=glibc - languageName: node - linkType: hard - "@rollup/rollup-linux-x64-gnu@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-x64-gnu@npm:4.27.4" @@ -1759,13 +1661,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-linux-x64-musl@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-linux-x64-musl@npm:4.27.3" - conditions: os=linux & cpu=x64 & libc=musl - languageName: node - linkType: hard - "@rollup/rollup-linux-x64-musl@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-linux-x64-musl@npm:4.27.4" @@ -1773,13 +1668,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-win32-arm64-msvc@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-win32-arm64-msvc@npm:4.27.3" - conditions: os=win32 & cpu=arm64 - languageName: node - linkType: hard - "@rollup/rollup-win32-arm64-msvc@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-win32-arm64-msvc@npm:4.27.4" @@ -1787,13 +1675,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-win32-ia32-msvc@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-win32-ia32-msvc@npm:4.27.3" - conditions: os=win32 & cpu=ia32 - languageName: node - linkType: hard - "@rollup/rollup-win32-ia32-msvc@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-win32-ia32-msvc@npm:4.27.4" @@ -1801,13 +1682,6 @@ __metadata: languageName: node linkType: hard -"@rollup/rollup-win32-x64-msvc@npm:4.27.3": - version: 4.27.3 - resolution: "@rollup/rollup-win32-x64-msvc@npm:4.27.3" - conditions: os=win32 & cpu=x64 - languageName: node - linkType: hard - "@rollup/rollup-win32-x64-msvc@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-win32-x64-msvc@npm:4.27.4" @@ -1986,11 +1860,11 @@ __metadata: linkType: hard "@types/node@npm:*": - version: 22.9.1 - resolution: "@types/node@npm:22.9.1" + version: 22.10.0 + resolution: "@types/node@npm:22.10.0" dependencies: - undici-types: "npm:~6.19.8" - checksum: 10/43fadcb3a914a1daff8e559839f235eec65fe80bfef5016b361dbc7952c9bc9d79456c78d89beab275a9e9e5accff37e838c019ab519f821f12c953cd6c24b50 + undici-types: "npm:~6.20.0" + checksum: 10/e2561e15eaac6261cf828cd7dcd4882a5ce2e10104db4123566b00418acf30e18518e39c7a906682f44118b420c555cc774ac3e0e6f80e37f55884cfe6cf1f78 languageName: node linkType: hard @@ -2392,13 +2266,13 @@ __metadata: linkType: hard "axios@npm:^1.7.4": - version: 1.7.7 - resolution: "axios@npm:1.7.7" + version: 1.7.8 + resolution: "axios@npm:1.7.8" dependencies: follow-redirects: "npm:^1.15.6" form-data: "npm:^4.0.0" proxy-from-env: "npm:^1.1.0" - checksum: 10/7f875ea13b9298cd7b40fd09985209f7a38d38321f1118c701520939de2f113c4ba137832fe8e3f811f99a38e12c8225481011023209a77b0c0641270e20cde1 + checksum: 10/7ddcde188041ac55090186254b4025eb2af842be3cf615ce45393fd7f543c1eab0ad2fdd2017a5f6190695e3ecea73ee5e9c37f204854aec2698f9579046efdf languageName: node linkType: hard @@ -5224,11 +5098,11 @@ __metadata: linkType: hard "magic-string@npm:^0.30.12": - version: 0.30.13 - resolution: "magic-string@npm:0.30.13" + version: 0.30.14 + resolution: "magic-string@npm:0.30.14" dependencies: "@jridgewell/sourcemap-codec": "npm:^1.5.0" - checksum: 10/1f46db78b0afcc5c6acb550f7a6ab7811417b72133ccb9d351d727e6bc17767042ff758a51d090f6f86e7b6c41b28ae0ef1cc8dbb8701a824901babc15f00a07 + checksum: 10/8ca0f8937c2824e48ebc70e7e065a193c467713639cc6e5972aaba0fa5417b375a6f62c383410a19a66e618c386bb7253fbd3ccbfb0144bb310f0ba772121f12 languageName: node linkType: hard @@ -5949,20 +5823,20 @@ __metadata: linkType: hard "nx@npm:>=17.1.2 < 21": - version: 20.1.2 - resolution: "nx@npm:20.1.2" + version: 20.1.3 + resolution: "nx@npm:20.1.3" dependencies: "@napi-rs/wasm-runtime": "npm:0.2.4" - "@nx/nx-darwin-arm64": "npm:20.1.2" - "@nx/nx-darwin-x64": "npm:20.1.2" - "@nx/nx-freebsd-x64": "npm:20.1.2" - "@nx/nx-linux-arm-gnueabihf": "npm:20.1.2" - "@nx/nx-linux-arm64-gnu": "npm:20.1.2" - "@nx/nx-linux-arm64-musl": "npm:20.1.2" - "@nx/nx-linux-x64-gnu": "npm:20.1.2" - "@nx/nx-linux-x64-musl": "npm:20.1.2" - "@nx/nx-win32-arm64-msvc": "npm:20.1.2" - "@nx/nx-win32-x64-msvc": "npm:20.1.2" + "@nx/nx-darwin-arm64": "npm:20.1.3" + "@nx/nx-darwin-x64": "npm:20.1.3" + "@nx/nx-freebsd-x64": "npm:20.1.3" + "@nx/nx-linux-arm-gnueabihf": "npm:20.1.3" + "@nx/nx-linux-arm64-gnu": "npm:20.1.3" + "@nx/nx-linux-arm64-musl": "npm:20.1.3" + "@nx/nx-linux-x64-gnu": "npm:20.1.3" + "@nx/nx-linux-x64-musl": "npm:20.1.3" + "@nx/nx-win32-arm64-msvc": "npm:20.1.3" + "@nx/nx-win32-x64-msvc": "npm:20.1.3" "@yarnpkg/lockfile": "npm:^1.1.0" "@yarnpkg/parsers": "npm:3.0.2" "@zkochan/js-yaml": "npm:0.0.7" @@ -6026,7 +5900,7 @@ __metadata: bin: nx: bin/nx.js nx-cloud: bin/nx-cloud.js - checksum: 10/1baf69f700db9ed1ba098645e669093636ebc5de35bfc1b632ef00f83cb348e0928868bbd951b2ddd40b523e6c1929230eaaffd96c4cc6c2ea9644fb05921170 + checksum: 10/e0e65381d146c83bceff52dd875915822ffce777190c85893990af51ba367e6e2093e42f38d687f8dd0f512b34fa6909773b4fac3de275980c5bd09f84ad23c8 languageName: node linkType: hard @@ -6938,7 +6812,7 @@ __metadata: languageName: node linkType: hard -"rollup@npm:4.27.4": +"rollup@npm:4.27.4, rollup@npm:^4.20.0, rollup@npm:^4.24.0": version: 4.27.4 resolution: "rollup@npm:4.27.4" dependencies: @@ -7007,75 +6881,6 @@ __metadata: languageName: node linkType: hard -"rollup@npm:^4.20.0, rollup@npm:^4.24.0": - version: 4.27.3 - resolution: "rollup@npm:4.27.3" - dependencies: - "@rollup/rollup-android-arm-eabi": "npm:4.27.3" - "@rollup/rollup-android-arm64": "npm:4.27.3" - "@rollup/rollup-darwin-arm64": "npm:4.27.3" - "@rollup/rollup-darwin-x64": "npm:4.27.3" - "@rollup/rollup-freebsd-arm64": "npm:4.27.3" - "@rollup/rollup-freebsd-x64": "npm:4.27.3" - "@rollup/rollup-linux-arm-gnueabihf": "npm:4.27.3" - "@rollup/rollup-linux-arm-musleabihf": "npm:4.27.3" - "@rollup/rollup-linux-arm64-gnu": "npm:4.27.3" - "@rollup/rollup-linux-arm64-musl": "npm:4.27.3" - "@rollup/rollup-linux-powerpc64le-gnu": "npm:4.27.3" - "@rollup/rollup-linux-riscv64-gnu": "npm:4.27.3" - "@rollup/rollup-linux-s390x-gnu": "npm:4.27.3" - "@rollup/rollup-linux-x64-gnu": "npm:4.27.3" - "@rollup/rollup-linux-x64-musl": "npm:4.27.3" - "@rollup/rollup-win32-arm64-msvc": "npm:4.27.3" - "@rollup/rollup-win32-ia32-msvc": "npm:4.27.3" - "@rollup/rollup-win32-x64-msvc": "npm:4.27.3" - "@types/estree": "npm:1.0.6" - fsevents: "npm:~2.3.2" - dependenciesMeta: - "@rollup/rollup-android-arm-eabi": - optional: true - "@rollup/rollup-android-arm64": - optional: true - "@rollup/rollup-darwin-arm64": - optional: true - "@rollup/rollup-darwin-x64": - optional: true - "@rollup/rollup-freebsd-arm64": - optional: true - "@rollup/rollup-freebsd-x64": - optional: true - "@rollup/rollup-linux-arm-gnueabihf": - optional: true - "@rollup/rollup-linux-arm-musleabihf": - optional: true - "@rollup/rollup-linux-arm64-gnu": - optional: true - "@rollup/rollup-linux-arm64-musl": - optional: true - "@rollup/rollup-linux-powerpc64le-gnu": - optional: true - "@rollup/rollup-linux-riscv64-gnu": - optional: true - "@rollup/rollup-linux-s390x-gnu": - optional: true - "@rollup/rollup-linux-x64-gnu": - optional: true - "@rollup/rollup-linux-x64-musl": - optional: true - "@rollup/rollup-win32-arm64-msvc": - optional: true - "@rollup/rollup-win32-ia32-msvc": - optional: true - "@rollup/rollup-win32-x64-msvc": - optional: true - fsevents: - optional: true - bin: - rollup: dist/bin/rollup - checksum: 10/8f77edb47acf734ecb7a20232d655b0ffe610f2d82e515917f66516137d6f55fdff6fff78285ee1921229cedaa161d8554f2b3cb2424cf489b0963fe024ec65f - languageName: node - linkType: hard - "rrweb-cssom@npm:^0.7.1": version: 0.7.1 resolution: "rrweb-cssom@npm:0.7.1" @@ -7724,21 +7529,21 @@ __metadata: languageName: node linkType: hard -"tldts-core@npm:^6.1.61": - version: 6.1.61 - resolution: "tldts-core@npm:6.1.61" - checksum: 10/44e80c5e587ab868750613336ac43ec1164d112d394958c220e54820595f3bf7b443a30ef6c73cd99234a897e41b70a4102a2fb8a9d7b40854973ed4e73c75d7 +"tldts-core@npm:^6.1.64": + version: 6.1.64 + resolution: "tldts-core@npm:6.1.64" + checksum: 10/1383a0edd2eee8fdb5d90c6f87b509954135c9032e104bbc5518f2eb5f48cbda27adaed0c5c6d8f9a940d3e63fc8ade781527035522ad4096968a8212a74b47b languageName: node linkType: hard "tldts@npm:^6.1.32": - version: 6.1.61 - resolution: "tldts@npm:6.1.61" + version: 6.1.64 + resolution: "tldts@npm:6.1.64" dependencies: - tldts-core: "npm:^6.1.61" + tldts-core: "npm:^6.1.64" bin: tldts: bin/cli.js - checksum: 10/dd2e1783fa0be71276e303be7a33f2746777e49eb0783452b42501edfc5a33b4396b54bd49b9268fc7e71a7fec58fb91064bdc4c4a50e1a1ada615e57ffa4bd8 + checksum: 10/776671db50c0b08f8fc4ee43f9328f377436ab008bcd72a58a3b0e2af9cae3447df015d4b079511b80627bd791fefb813d08857385a3dfdc6803317836276f92 languageName: node linkType: hard @@ -7991,7 +7796,7 @@ __metadata: languageName: node linkType: hard -"typescript@npm:5.6.3, typescript@npm:>=3 < 6": +"typescript@npm:5.6.3": version: 5.6.3 resolution: "typescript@npm:5.6.3" bin: @@ -8001,7 +7806,7 @@ __metadata: languageName: node linkType: hard -"typescript@npm:5.7.2": +"typescript@npm:5.7.2, typescript@npm:>=3 < 6": version: 5.7.2 resolution: "typescript@npm:5.7.2" bin: @@ -8021,7 +7826,7 @@ __metadata: languageName: node linkType: hard -"typescript@patch:typescript@npm%3A5.6.3#optional!builtin, typescript@patch:typescript@npm%3A>=3 < 6#optional!builtin": +"typescript@patch:typescript@npm%3A5.6.3#optional!builtin": version: 5.6.3 resolution: "typescript@patch:typescript@npm%3A5.6.3#optional!builtin::version=5.6.3&hash=8c6c40" bin: @@ -8031,7 +7836,7 @@ __metadata: languageName: node linkType: hard -"typescript@patch:typescript@npm%3A5.7.2#optional!builtin": +"typescript@patch:typescript@npm%3A5.7.2#optional!builtin, typescript@patch:typescript@npm%3A>=3 < 6#optional!builtin": version: 5.7.2 resolution: "typescript@patch:typescript@npm%3A5.7.2#optional!builtin::version=5.7.2&hash=cef18b" bin: @@ -8057,6 +7862,13 @@ __metadata: languageName: node linkType: hard +"undici-types@npm:~6.20.0": + version: 6.20.0 + resolution: "undici-types@npm:6.20.0" + checksum: 10/583ac7bbf4ff69931d3985f4762cde2690bb607844c16a5e2fbb92ed312fe4fa1b365e953032d469fa28ba8b224e88a595f0b10a449332f83fa77c695e567dbe + languageName: node + linkType: hard + "undici@npm:5.28.4": version: 5.28.4 resolution: "undici@npm:5.28.4" diff --git a/config/generation.config.mjs b/config/generation.config.mjs index d679d7bb00..22a1821a0d 100644 --- a/config/generation.config.mjs +++ b/config/generation.config.mjs @@ -81,6 +81,7 @@ export const patterns = [ '!clients/algoliasearch-client-javascript/packages/algoliasearch/vitest.workspace.ts', 'tests/output/javascript/package.json', + '!tests/output/javascript/yarn.lock', // Kotlin '!clients/algoliasearch-client-kotlin/**', diff --git a/playground/javascript/node/search.ts b/playground/javascript/node/search.ts index 054d3f470f..ec050c144b 100644 --- a/playground/javascript/node/search.ts +++ b/playground/javascript/node/search.ts @@ -17,11 +17,10 @@ console.log('version', apiClientVersion, 'requests', requests); async function testSearch() { try { - const res = await client.browseRules({ + const res = await client.saveRules({ indexName: 'cts_e2e_search_facet', - aggregator: (resp: any) => { - console.log(resp); - }, + rules:[{objectID:'foo', consequence:{params:{hitsPerPage:30}}}], + forwardToReplicas:true, }); console.log(`[OK]`, res); diff --git a/specs/search/paths/rules/common/schemas.yml b/specs/search/paths/rules/common/schemas.yml index 1bada84b2b..75e67f2dee 100644 --- a/specs/search/paths/rules/common/schemas.yml +++ b/specs/search/paths/rules/common/schemas.yml @@ -33,6 +33,7 @@ rule: $ref: '../../../../common/schemas/Rule.yml#/timeRange' required: - objectID + - consequence condition: type: object diff --git a/templates/javascript/clients/rollup.config.mustache b/templates/javascript/clients/rollup.config.mustache index 727635c703..eacbcf666d 100644 --- a/templates/javascript/clients/rollup.config.mustache +++ b/templates/javascript/clients/rollup.config.mustache @@ -2,6 +2,7 @@ export default [ { input: 'dist/{{#isAlgoliasearchClient}}lite/{{/isAlgoliasearchClient}}builds/browser.min.js', external: ['dom'], + cache: false, output: { esModule: false, file: 'dist/{{#isAlgoliasearchClient}}lite/{{/isAlgoliasearchClient}}builds/browser.umd.js', diff --git a/tests/CTS/requests/search/saveRule.json b/tests/CTS/requests/search/saveRule.json index d4bc235cd1..9ec0e86095 100644 --- a/tests/CTS/requests/search/saveRule.json +++ b/tests/CTS/requests/search/saveRule.json @@ -11,7 +11,12 @@ "pattern": "apple", "anchoring": "contains" } - ] + ], + "consequence": { + "params": { + "filters": "brand:xiaomi" + } + } } }, "request": { @@ -24,7 +29,12 @@ "pattern": "apple", "anchoring": "contains" } - ] + ], + "consequence": { + "params": { + "filters": "brand:xiaomi" + } + } } } }, diff --git a/tests/CTS/requests/search/saveRules.json b/tests/CTS/requests/search/saveRules.json index 91f91ea5c4..416e8168ea 100644 --- a/tests/CTS/requests/search/saveRules.json +++ b/tests/CTS/requests/search/saveRules.json @@ -11,7 +11,12 @@ "pattern": "smartphone", "anchoring": "contains" } - ] + ], + "consequence": { + "params": { + "filters": "brand:apple" + } + } }, { "objectID": "a-second-rule-id", @@ -20,7 +25,12 @@ "pattern": "apple", "anchoring": "contains" } - ] + ], + "consequence": { + "params": { + "filters": "brand:samsung" + } + } } ], "forwardToReplicas": false, @@ -37,7 +47,12 @@ "pattern": "smartphone", "anchoring": "contains" } - ] + ], + "consequence": { + "params": { + "filters": "brand:apple" + } + } }, { "objectID": "a-second-rule-id", @@ -46,7 +61,12 @@ "pattern": "apple", "anchoring": "contains" } - ] + ], + "consequence": { + "params": { + "filters": "brand:samsung" + } + } } ], "queryParameters": { diff --git a/yarn.lock b/yarn.lock index 073aa92cb6..cecb8f97d4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1296,11 +1296,11 @@ __metadata: linkType: hard "@octokit/types@npm:^13.0.0, @octokit/types@npm:^13.1.0, @octokit/types@npm:^13.6.0, @octokit/types@npm:^13.6.1": - version: 13.6.1 - resolution: "@octokit/types@npm:13.6.1" + version: 13.6.2 + resolution: "@octokit/types@npm:13.6.2" dependencies: "@octokit/openapi-types": "npm:^22.2.0" - checksum: 10/9ea6189839439e1085799cc16ee699292538d9c14dd15e9e45462377287f863b6be93455d2ad9acffd561018a0c35adbb9d1437e92075c9058d6c6d69ff2f503 + checksum: 10/8e614796f3554d28dfb77c570e80ef52d68ef311bdd4614ec263f8ea2266b9c06d4f7963fe2989f32cbfe4ea0c05e13eba9a64a6e0f64afb997cd975af154d52 languageName: node linkType: hard @@ -1504,7 +1504,7 @@ __metadata: languageName: node linkType: hard -"@redocly/openapi-core@npm:1.25.13, @redocly/openapi-core@npm:^1.4.0": +"@redocly/openapi-core@npm:1.25.13": version: 1.25.13 resolution: "@redocly/openapi-core@npm:1.25.13" dependencies: @@ -1523,6 +1523,25 @@ __metadata: languageName: node linkType: hard +"@redocly/openapi-core@npm:^1.4.0": + version: 1.25.14 + resolution: "@redocly/openapi-core@npm:1.25.14" + dependencies: + "@redocly/ajv": "npm:^8.11.2" + "@redocly/config": "npm:^0.16.0" + colorette: "npm:^1.2.0" + https-proxy-agent: "npm:^7.0.4" + js-levenshtein: "npm:^1.1.6" + js-yaml: "npm:^4.1.0" + lodash.isequal: "npm:^4.5.0" + minimatch: "npm:^5.0.1" + node-fetch: "npm:^2.6.1" + pluralize: "npm:^8.0.0" + yaml-ast-parser: "npm:0.0.43" + checksum: 10/df2bd8638cd1f56f798c27c268c45ce0b3e1f755c7ec3d06bacd7e8502d9fdc1287d6f25ea37a3462b161cc6ff1f48c0fcbf462e79139286820975b86dc758ff + languageName: node + linkType: hard + "@rollup/rollup-android-arm-eabi@npm:4.27.4": version: 4.27.4 resolution: "@rollup/rollup-android-arm-eabi@npm:4.27.4" @@ -1797,7 +1816,16 @@ __metadata: languageName: node linkType: hard -"@types/node@npm:*, @types/node@npm:22.9.3": +"@types/node@npm:*": + version: 22.10.0 + resolution: "@types/node@npm:22.10.0" + dependencies: + undici-types: "npm:~6.20.0" + checksum: 10/e2561e15eaac6261cf828cd7dcd4882a5ce2e10104db4123566b00418acf30e18518e39c7a906682f44118b420c555cc774ac3e0e6f80e37f55884cfe6cf1f78 + languageName: node + linkType: hard + +"@types/node@npm:22.9.3": version: 22.9.3 resolution: "@types/node@npm:22.9.3" dependencies: @@ -1869,29 +1897,29 @@ __metadata: languageName: node linkType: hard -"@typescript-eslint/scope-manager@npm:8.15.0": - version: 8.15.0 - resolution: "@typescript-eslint/scope-manager@npm:8.15.0" +"@typescript-eslint/scope-manager@npm:8.16.0": + version: 8.16.0 + resolution: "@typescript-eslint/scope-manager@npm:8.16.0" dependencies: - "@typescript-eslint/types": "npm:8.15.0" - "@typescript-eslint/visitor-keys": "npm:8.15.0" - checksum: 10/70abd5f049c5568a1b33391d85b5842ffae513f5b2bb5630bd26619a50e41ea5e6b620970958f94e0129ffff9ab69997f396f782195923aa45dfbb2df0941a14 + "@typescript-eslint/types": "npm:8.16.0" + "@typescript-eslint/visitor-keys": "npm:8.16.0" + checksum: 10/e0aea61f248b39049d4ce21c19f9c8af1a8024f4f92abc8c1d5b79ea65b013c6c4ff41efb92995050036aa95b6a705601917b56809d9ec1fbbab387054aeb269 languageName: node linkType: hard -"@typescript-eslint/types@npm:8.15.0": - version: 8.15.0 - resolution: "@typescript-eslint/types@npm:8.15.0" - checksum: 10/d31605748984794e586ed62e9052bd3794ba646ae75f60b9da5de644ad0e76aa64e47386a4e113ba2d66836927e03c836586ef586261c8ae627acc06fb7e275c +"@typescript-eslint/types@npm:8.16.0": + version: 8.16.0 + resolution: "@typescript-eslint/types@npm:8.16.0" + checksum: 10/b37b26cd0e45b0cd6f7d492a07af583e4877d798495ab5fc1cfacb3c561b6d7981e3166f0475bb997e6c6d56ef903e160895174c7e63c08322dbb42d026cf7dc languageName: node linkType: hard -"@typescript-eslint/typescript-estree@npm:8.15.0": - version: 8.15.0 - resolution: "@typescript-eslint/typescript-estree@npm:8.15.0" +"@typescript-eslint/typescript-estree@npm:8.16.0": + version: 8.16.0 + resolution: "@typescript-eslint/typescript-estree@npm:8.16.0" dependencies: - "@typescript-eslint/types": "npm:8.15.0" - "@typescript-eslint/visitor-keys": "npm:8.15.0" + "@typescript-eslint/types": "npm:8.16.0" + "@typescript-eslint/visitor-keys": "npm:8.16.0" debug: "npm:^4.3.4" fast-glob: "npm:^3.3.2" is-glob: "npm:^4.0.3" @@ -1901,34 +1929,34 @@ __metadata: peerDependenciesMeta: typescript: optional: true - checksum: 10/e9bf3aab855578f046e0a91ff91a7d08423a5c8bc0bedfc5f2af3c9b6eb98a9fe693a23e4bf56791930e838de16811ce91edae07702c9621c0ad7a56838c7c0c + checksum: 10/823cf55d331cf7283547a2860a5d7bfd7dbd497be6e87b226dd7456b36db214de1504855afbbaef8d89932c11a1e589d4cb2a4093b6f1c542a4ce8319d988006 languageName: node linkType: hard "@typescript-eslint/utils@npm:^8.1.0": - version: 8.15.0 - resolution: "@typescript-eslint/utils@npm:8.15.0" + version: 8.16.0 + resolution: "@typescript-eslint/utils@npm:8.16.0" dependencies: "@eslint-community/eslint-utils": "npm:^4.4.0" - "@typescript-eslint/scope-manager": "npm:8.15.0" - "@typescript-eslint/types": "npm:8.15.0" - "@typescript-eslint/typescript-estree": "npm:8.15.0" + "@typescript-eslint/scope-manager": "npm:8.16.0" + "@typescript-eslint/types": "npm:8.16.0" + "@typescript-eslint/typescript-estree": "npm:8.16.0" peerDependencies: eslint: ^8.57.0 || ^9.0.0 peerDependenciesMeta: typescript: optional: true - checksum: 10/22f6d5727aabbcd108ca2cc0563e85ec3a616759a9ef8aae6c22687e6dc8da3dc2a1ea3e075b811cad5512451bb26fe90d74ebba573c2ba7d219c9a4256a1787 + checksum: 10/80ba35b97a8e80ac2b54a56ac041b4f4583328d764e1693e7d3750de383cbcefcb7e838b75e550e8aa4df446f4b41460da6dc83543517280a4e3a61546c1a8dc languageName: node linkType: hard -"@typescript-eslint/visitor-keys@npm:8.15.0": - version: 8.15.0 - resolution: "@typescript-eslint/visitor-keys@npm:8.15.0" +"@typescript-eslint/visitor-keys@npm:8.16.0": + version: 8.16.0 + resolution: "@typescript-eslint/visitor-keys@npm:8.16.0" dependencies: - "@typescript-eslint/types": "npm:8.15.0" + "@typescript-eslint/types": "npm:8.16.0" eslint-visitor-keys: "npm:^4.2.0" - checksum: 10/31916783cd038ab46a0012d6c664e4d93409b12e911dd1d2fe122506d82fda0ec2411d63632b90c19cd39451c8abfb7a138b0918a4e22019e328c4709748c806 + checksum: 10/e3f231a3e8ca2f7a3dc0e9ebdc3ea1f51a377b1285727413b4c89c44dbfaf342f2574b1b4e7f478f295963045a6058e27b4827816fe2a5a2d09f565eb68522c7 languageName: node linkType: hard @@ -5580,11 +5608,11 @@ __metadata: linkType: hard "magic-string@npm:^0.30.12": - version: 0.30.13 - resolution: "magic-string@npm:0.30.13" + version: 0.30.14 + resolution: "magic-string@npm:0.30.14" dependencies: "@jridgewell/sourcemap-codec": "npm:^1.5.0" - checksum: 10/1f46db78b0afcc5c6acb550f7a6ab7811417b72133ccb9d351d727e6bc17767042ff758a51d090f6f86e7b6c41b28ae0ef1cc8dbb8701a824901babc15f00a07 + checksum: 10/8ca0f8937c2824e48ebc70e7e065a193c467713639cc6e5972aaba0fa5417b375a6f62c383410a19a66e618c386bb7253fbd3ccbfb0144bb310f0ba772121f12 languageName: node linkType: hard @@ -8065,11 +8093,11 @@ __metadata: linkType: hard "ts-api-utils@npm:^1.3.0": - version: 1.4.1 - resolution: "ts-api-utils@npm:1.4.1" + version: 1.4.2 + resolution: "ts-api-utils@npm:1.4.2" peerDependencies: typescript: ">=4.2.0" - checksum: 10/2f32698ed1c06e57d934704ff2579a905895441ef0a29f732242d3d3f651abd5d09610f702c656e85b73457582a1ded43adeef82e9f6d665ae0fb66497cf39f6 + checksum: 10/9c92217d4eb9ee656f19181c412d01e7b4370faa21de1d5cc0edf972d416eeabf4422343b40c574462a27329afa8dcf9795223b253a6abc8695a079700893b64 languageName: node linkType: hard @@ -8305,6 +8333,13 @@ __metadata: languageName: node linkType: hard +"undici-types@npm:~6.20.0": + version: 6.20.0 + resolution: "undici-types@npm:6.20.0" + checksum: 10/583ac7bbf4ff69931d3985f4762cde2690bb607844c16a5e2fbb92ed312fe4fa1b365e953032d469fa28ba8b224e88a595f0b10a449332f83fa77c695e567dbe + languageName: node + linkType: hard + "undici@npm:^5.25.4": version: 5.28.4 resolution: "undici@npm:5.28.4"