Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2230 - prevent babel helpers duplication and condense bundle & types #2278

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix #2230 - prevent babel helpers duplication and condense bundle & types #2278

merged 3 commits into from
Jul 16, 2024

Conversation

levimichael
Copy link
Contributor

@levimichael levimichael commented Jul 15, 2024 •
edited

  • Fixes ESM output contains many duplicated helpers #2230, by condensing the ESM bundle into a single file
  • Usesrollup-plugin-dts to merge the types into one index.d.ts file
  • Uses @rollup/plugin instead of manually passing the bundle to Babel post-build, and replaces rollup-plugin-babel usage

@netlify Netlify
Copy link

netlify bot commented Jul 15, 2024 •
edited

✅ Deploy Preview for docsearch ready!

Name Link
🔨 Latest commit d31ad7b
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/66958da6f131f10008bdd969
😎 Deploy Preview https://deploy-preview-2278--docsearch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@8bittitan
Copy link
Contributor

If we are taking the time to update these, what do you think about moving to something like tsup overall? https://tsup.egoist.dev/

@8bittitan
Copy link
Contributor

Should we also do this for the docsearch-js implementation as well?

@levimichael
Copy link
Contributor Author

If we are taking the time to update these, what do you think about moving to something like tsup overall? https://tsup.egoist.dev/

Interesting idea, I'm not sure its worth the effort currently to swap out the bundler. We can revisit this in another PR!

@levimichael
Copy link
Contributor Author

Should we also do this for the docsearch-js implementation as well?

Updated!

@levimichael levimichael merged commit 29aa9e6 into main Jul 16, 2024
10 checks passed
@levimichael levimichael deleted the fix/rollup-esm-bundle branch July 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8bittitan 8bittitan 8bittitan approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner

@francoischalifour francoischalifour Awaiting requested review from francoischalifour francoischalifour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESM output contains many duplicated helpers
2 participants
@levimichael @8bittitan