fix: docsearch input should have aria-label (a11y) #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops dont merge it yet. test failing |
|
Ok I've updated the test. It is now ready to merge
P.S: I wonder why the travis CI doesn't have test invoked |
|
Great thanks |
s-pace
pushed a commit
that referenced
this pull request
May 13, 2019
### Bug Fixes * **deps:** update dependency autocomplete.js to v0.35.0 ([2d67a21](2d67a21)) * **deps:** update dependency autocomplete.js to v0.36.0 ([bbd4ef5](bbd4ef5)) * **security:** Fix dependencies to avoid infected event-stream ([9f93ffb](9f93ffb)) * docsearch input should have aria-label (a11y) ([#687](#687)) ([59d21f5](59d21f5)) * search input a11y issue ([#679](#679)) ([a68d2a4](a68d2a4))
s-pace
pushed a commit
that referenced
this pull request
Aug 22, 2019
* fix: search input a11y issue * fix: docsearch input should have aria-label (a11y) * update test
s-pace
pushed a commit
that referenced
this pull request
Aug 22, 2019
### Bug Fixes * **deps:** update dependency autocomplete.js to v0.35.0 ([2d67a21](2d67a21)) * **deps:** update dependency autocomplete.js to v0.36.0 ([bbd4ef5](bbd4ef5)) * **security:** Fix dependencies to avoid infected event-stream ([9f93ffb](9f93ffb)) * docsearch input should have aria-label (a11y) ([#687](#687)) ([59d21f5](59d21f5)) * search input a11y issue ([#679](#679)) ([a68d2a4](a68d2a4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to continue work on #679
Previously it was reverted because there is no safe getter 😭
Result
aria-label exist
