Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-import unmet peer dependency #37

Closed
rayrutjes opened this issue Jun 16, 2017 · 7 comments
Closed

eslint-plugin-import unmet peer dependency #37

rayrutjes opened this issue Jun 16, 2017 · 7 comments

Comments

@rayrutjes
Copy link
Member

The eslint-plugin-import lib does not currently support eslint 4.
We will need to update once this is merged: import-js/eslint-plugin-import#871

@vvo
Copy link
Contributor

vvo commented Jun 16, 2017

It is supported but there's a warning for now yes.

@vvo
Copy link
Contributor

vvo commented Jun 16, 2017

But it works

@rayrutjes
Copy link
Member Author

I tried to add https://github.com/vuejs/eslint-plugin-vue to have better warnings for .vue files, but I found no way to make it work in the current config.

yarn lint                                   ⏎ ✹
yarn lint v0.24.6
$ eslint --ext .js,.vue .
Cannot read property 'some' of undefined
TypeError: Cannot read property 'some' of undefined
    at Object.isUnambiguousModule [as isModule] (/Users/raymond/Code/vue-instantsearch/node_modules/eslint-module-utils/unambiguous.js:29:18)
    at Function.ExportMap.parse (/Users/raymond/Code/vue-instantsearch/node_modules/eslint-plugin-import/lib/ExportMap.js:348:20)
    at Function.ExportMap.for (/Users/raymond/Code/vue-instantsearch/node_modules/eslint-plugin-import/lib/ExportMap.js:326:25)
    at Function.ExportMap.get (/Users/raymond/Code/vue-instantsearch/node_modules/eslint-plugin-import/lib/ExportMap.js:284:23)
    at processBodyStatement (/Users/raymond/Code/vue-instantsearch/node_modules/eslint-plugin-import/lib/rules/namespace.js:58:47)
    at Array.forEach (native)
    at Linter.Program (/Users/raymond/Code/vue-instantsearch/node_modules/eslint-plugin-import/lib/rules/namespace.js:87:14)
    at emitOne (events.js:101:20)
    at Linter.emit (events.js:191:7)
    at NodeEventGenerator.applySelector (/Users/raymond/Code/vue-instantsearch/node_modules/eslint/lib/util/node-event-generator.js:265:26)
error Command failed with exit code 1.

@vvo
Copy link
Contributor

vvo commented Jun 17, 2017

This is something different, see the issue on vue rslint plugin and also the readme here explains it

@rayrutjes
Copy link
Member Author

I think you forgot the link ;)

@vvo
Copy link
Contributor

vvo commented Jun 19, 2017

vuejs/eslint-plugin-vue#21 (comment)

Also they just fixed the vue template plugin so that import plugin works alongside, import plugin might still say it's not compatible with latest eslint but it is.

@vvo
Copy link
Contributor

vvo commented Jun 19, 2017

(this warning is not an issue right now)

@vvo vvo closed this as completed Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants