From 32a2c2aca9f13634c5e2bb7f335394ce3c784931 Mon Sep 17 00:00:00 2001 From: A Jordan Simonds Date: Mon, 4 Dec 2017 16:07:26 -0500 Subject: [PATCH 1/2] fix: Powered-by component is not SSR compatible algolia/vue-instantsearch#367 Add a null check to the `location` reference in `algoliaUrl`. fixes algolia/vue-instantsearch#367 --- packages/vue-instantsearch/src/components/PoweredBy.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue-instantsearch/src/components/PoweredBy.vue b/packages/vue-instantsearch/src/components/PoweredBy.vue index 8331d68eaf..a4bf26d999 100644 --- a/packages/vue-instantsearch/src/components/PoweredBy.vue +++ b/packages/vue-instantsearch/src/components/PoweredBy.vue @@ -43,7 +43,7 @@ export default { 'https://www.algolia.com/?' + 'utm_source=vue-instantsearch&' + 'utm_medium=website&' + - `utm_content=${location.hostname}&` + + ( location ? `utm_content=${location.hostname}&` : '' ) + 'utm_campaign=poweredby' ); }, From 310f13b9d757662dbd5a031c7263bfb743c34e62 Mon Sep 17 00:00:00 2001 From: A Jordan Simonds Date: Mon, 4 Dec 2017 16:16:14 -0500 Subject: [PATCH 2/2] fix test fialures --- packages/vue-instantsearch/src/components/PoweredBy.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vue-instantsearch/src/components/PoweredBy.vue b/packages/vue-instantsearch/src/components/PoweredBy.vue index a4bf26d999..7d0dfcb757 100644 --- a/packages/vue-instantsearch/src/components/PoweredBy.vue +++ b/packages/vue-instantsearch/src/components/PoweredBy.vue @@ -43,7 +43,7 @@ export default { 'https://www.algolia.com/?' + 'utm_source=vue-instantsearch&' + 'utm_medium=website&' + - ( location ? `utm_content=${location.hostname}&` : '' ) + + `utm_content=${location ? location.hostname : ''}&` + 'utm_campaign=poweredby' ); },