This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(DOMMaps): expose withGoogleMaps HOC [PART-1] #2000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new HOC for the maps package. It's now part of the public API because we export this component. The HOC gives access to the
google
object and thegoogleMapsInstance
which is the instance of the map.Users might want to leverage this to create their own layer on top of our geo search widget. It was already the case with the heatmap PR. Now it's possible to build it in user-land.
We choose the HOC over a render prop because it's easier to build a component with lifecycle hooks out of an HOC. With a render prop you have to create a layer to extract the value and provide it to the component that will use it. We can built an HOC out of render prop so if someone ask for it we can refactor the API to provide both.
Usage