This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(voice): add additionalQueryParameters #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 4d8488d https://deploy-preview-2366--react-instantsearch.netlify.com |
Haroenv
reviewed
Apr 29, 2019
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-dom/src/components/VoiceSearch.tsx
Outdated
Show resolved
Hide resolved
marieglr
force-pushed
the
poc/voice-parameters
branch
from
4d8488d to
5d4904a
Compare
marieglr
force-pushed
the
poc/voice-parameters
branch
from
5d4904a to
a296742
Compare
marieglr
force-pushed
the
poc/voice-parameters
branch
from
a296742 to
e79488a
Compare
Two new props: - `additionalQueryParameters: () => Partial<SearchParameters>` (only applied when voice search is mounted) - `language: string` (iso 639-1), the parameter sent to Algolia will be always the short version known limitation: additional query parameters will stay applied as long as the Voice Search widget is mounted, meaning they can cause stale values if you switch input method without unmounting (limitation of the architecture of React InstantSearch) This does not have additional tests yet. The connector is written in JS instead of TS, because it's mostly copy-pasted from searchBox, and that would be needless extra work otherwise #hackathon Co-Authored-By: Haroenv <haroen@algolia.com>
Haroenv
force-pushed
the
poc/voice-parameters
branch
from
e79488a to
8983f7a
Compare
ghost
requested review from
francoischalifour and
tkrugg
and removed request for
a team
Haroenv
reviewed
Oct 14, 2019
packages/react-instantsearch-core/src/connectors/connectVoiceSearch.js
Outdated
Show resolved
Hide resolved
tkrugg
requested review from
yannickcr
and removed request for
tkrugg and
francoischalifour
|
@Haroenv could you review the recent commits? |
Haroenv
reviewed
Nov 19, 2019
There was a problem hiding this comment.
looks ready to me now @eunjae-lee, just maybe tests for multi-index (as far as I can tell it will just work)
added some tests for multi index 349b03e |
Haroenv
approved these changes
Nov 19, 2019
yannickcr
reviewed
Nov 20, 2019
packages/react-instantsearch-core/src/connectors/connectVoiceSearch.js
Outdated
Show resolved
Hide resolved
I wrote this in the original description, but since it's mostly the same as search box, and the patterns for connectors aren't yet clear in React InstantSearch, I didn't do this in this PR |
yannickcr
approved these changes
Nov 20, 2019
Haroenv
pushed a commit
that referenced
this pull request
Nov 20, 2019
* feat(voice): add additionalQueryParameters Two new props: - `additionalQueryParameters: () => Partial<SearchParameters>` (only applied when voice search is mounted) - `language: string` (iso 639-1), the parameter sent to Algolia will be always the short version known limitation: additional query parameters will stay applied as long as the Voice Search widget is mounted, meaning they can cause stale values if you switch input method without unmounting (limitation of the architecture of React InstantSearch) This does not have additional tests yet. The connector is written in JS instead of TS, because it's mostly copy-pasted from searchBox, and that would be needless extra work otherwise #hackathon Co-Authored-By: Haroenv <haroen@algolia.com> * chore(size): update bundle size (this change is +270b) * feat(voice): handle language and additionalQueryParameters separately * feat(voice): add tests * feat(voice): add tests for multi index * feat(voice): add test for additionalVoiceParameters * chore: remove unused argument
|
accidentally merged into next instead of master, but fixed in 3a45b2c |
Haroenv
added a commit
that referenced
this pull request
Dec 17, 2019
# [6.1.0](v6.0.0...v6.1.0) (2019-12-17) ### Bug Fixes * **connectNumericMenu:** support numeric refinement 0 ([#2882](#2882)) ([30bd9fd](30bd9fd)) * **deps:** update dependency next to v9.1.1 ([9d49d33](9d49d33)) * **helper:** rely on stable version of algoliasearch-helper ([#2871](#2871)) ([e3531a1](e3531a1)) ### Features * **insights:** show an error when 'clickAnalytics: true' is missing. ([#2877](#2877)) ([621656a](621656a)) * **voice:** add additionalQueryParameters ([#2366](#2366)) ([3a45b2c](3a45b2c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new props:
additionalQueryParameters: () => Partial<SearchParameters>(only applied when voice search is mounted)language: string(iso 639-1), the parameter sent to Algolia will be always the short versionNew connector:
connectVoiceSearchknown limitation: additional query parameters will stay applied as long as the Voice Search widget is mounted, meaning they can cause stale values if you switch input method without unmounting (limitation of the architecture of React InstantSearch)
The connector is written in JS instead of TS, because it's mostly copy-pasted from searchBox, and that would be needless extra work otherwise #hackathon
fixes #2874