Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

ERROR - Recent changes in instantsearch.js do break getServerState #3623

Closed
DB-Alex opened this issue Sep 15, 2022 · 3 comments · Fixed by #3622
Closed

ERROR - Recent changes in instantsearch.js do break getServerState #3623

DB-Alex opened this issue Sep 15, 2022 · 3 comments · Fixed by #3622

Comments

@DB-Alex
Copy link

DB-Alex commented Sep 15, 2022

@Haroenv Your recent commit breaks the server hooks plugin:

algolia/instantsearch@231853d#diff-e78e1b9a02a935bbc87df77904b2f68b97e32d459a1ad8710f4fab1386375d61

error: file:///node_modules/react-instantsearch-hooks-server/dist/es/getServerState.js:7
import { isIndexWidget } from "instantsearch.js/es/widgets/index/index.js";

SyntaxError: The requested module 'instantsearch.js/es/widgets/index/index.js' does not provide an export named 'isIndexWidget'

Versions:

"react-instantsearch-hooks-server": "^6.32.1",
"react-instantsearch-hooks-web": "^6.32.1",

I submitted a pullrequest here:

#3624

@Haroenv
Copy link
Contributor

Haroenv commented Sep 15, 2022

Thanks for noticing this, I didn't know React InstantSearch Hooks was importing from private paths :( I've incorporated the fix in #3622, as the new path only works from that version of InstantSearch.js too

@DB-Alex
Copy link
Author

DB-Alex commented Sep 15, 2022

Thanks for the quick fix!

@Haroenv
Copy link
Contributor

Haroenv commented Sep 15, 2022

The fix is released in 6.33.0, thanks for listing a suggested fix too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants