Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

/es/ folder doesn't contain es2015 code, but commonjs #499

Closed
Haroenv opened this issue Oct 17, 2017 · 4 comments
Closed

/es/ folder doesn't contain es2015 code, but commonjs #499

Haroenv opened this issue Oct 17, 2017 · 4 comments

Comments

@Haroenv
Copy link
Contributor

Haroenv commented Oct 17, 2017

Do you want to request a feature or report a bug?

bug I guess

Bug: What is the current behavior?

the es folder contains the same as the main folder

see https://unpkg.com/react-instantsearch@4.1.3/es/

Bug: What is the expected behavior?

the es folder to contain es2015 modules

What is the version you are using? Always use the latest one before opening a bug issue.

4.1.3

@Haroenv
Copy link
Contributor Author

Haroenv commented Oct 17, 2017

This might be because the env is broken in babel babel/babel#5276, we can move to .babelrc.js and have a way simpler config

@mthuret
Copy link
Contributor

mthuret commented Oct 18, 2017

Could you handle this @Haroenv?

@Haroenv
Copy link
Contributor Author

Haroenv commented Nov 3, 2017

Very weird that #547 didn't fix this, but it's still the case: https://unpkg.com/react-instantsearch@4.2.0/es/connectors.js

@Haroenv Haroenv reopened this Nov 3, 2017
@Haroenv
Copy link
Contributor Author

Haroenv commented Nov 3, 2017

oops, this wasn't in 4.2.0 yet 😄

@Haroenv Haroenv closed this as completed Nov 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants