fix(prepare): clean up remote origin-with-token after git push (#479)

* fix(prepare): clean up remote `origin-with-token` after git push * fix: update test snapshot
algolia · Dec 1, 2019 · c81d247 · c81d247
1 parent 51e5ab2
commit c81d247
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/shipjs/src/helper/__tests__/gitPush.spec.js b/packages/shipjs/src/helper/__tests__/gitPush.spec.js
@@ -36,7 +36,7 @@ describe('gitPush', () => {
         "    $ git remote add origin-with-token https://xxx@github.com/my/repo",
       ]
     `);
-    expect(run).toHaveBeenCalledTimes(3);
+    expect(run).toHaveBeenCalledTimes(4);
     expect(run.mock.calls[0][0]).toMatchInlineSnapshot(`
       Object {
         "command": "git remote add origin-with-token https://abcdef@github.com/my/repo",
@@ -59,6 +59,14 @@ describe('gitPush', () => {
         "dryRun": false,
       }
     `);
+    expect(run.mock.calls[3][0]).toMatchInlineSnapshot(`
+      Object {
+        "command": "git remote remove origin-with-token",
+        "dir": ".",
+        "dryRun": false,
+        "printCommand": false,
+      }
+    `);
   });
 
   it('works without token', () => {

diff --git a/packages/shipjs/src/helper/gitPush.js b/packages/shipjs/src/helper/gitPush.js
@@ -22,6 +22,12 @@ export default function gitPush({ remote, refs, dir, dryRun }) {
     refs.forEach(ref => {
       run({ command: `git push origin-with-token ${ref}`, dir, dryRun });
     });
+    run({
+      command: `git remote remove origin-with-token`,
+      dir,
+      dryRun,
+      printCommand: false,
+    });
   } else {
     refs.forEach(ref => {
       run({