Skip to content

Commit

Permalink
fix: fix --no-browse option (#195)
Browse files Browse the repository at this point in the history
  • Loading branch information
Eunjae Lee committed Aug 20, 2019
1 parent 06c6977 commit f923e52
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions packages/shipjs/src/flow/prepare.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ async function prepare({
firstRelease = false,
releaseCount,
dryRun = false,
noBrowse = false,
}) {
if (help) {
printHelp();
Expand Down Expand Up @@ -61,6 +62,7 @@ async function prepare({
stagingBranch,
currentVersion,
nextVersion,
noBrowse,
config,
dir,
dryRun,
Expand Down
3 changes: 2 additions & 1 deletion packages/shipjs/src/step/prepare/createPullRequest.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export default ({
stagingBranch,
currentVersion,
nextVersion,
noBrowse,
config,
dir,
dryRun,
Expand Down Expand Up @@ -60,7 +61,7 @@ export default ({
const createPullRequestCommand = [
'hub pull-request',
`--base ${destinationBranch}`,
'--browse',
noBrowse ? undefined : '--browse',
'--push',
pullRequestReviewer ? `--reviewer ${pullRequestReviewer}` : undefined,
`--file ${filePath}`,
Expand Down

0 comments on commit f923e52

Please sign in to comment.