Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the actions/github-script action instead of the deprecated actions/github action #934

Merged
merged 1 commit into from
Nov 3, 2020
Merged

fix: use the actions/github-script action instead of the deprecated actions/github action #934

merged 1 commit into from
Nov 3, 2020

Conversation

miyajan
Copy link
Contributor

@miyajan miyajan commented Nov 3, 2020

The GitHub Actions jobs created by shipjs setup use the actions/github action. But the actions/github action is deprecated and it is recommended to use the actions/github-script action instead.

https://github.com/actions/github

🚨 This action is deprecated! Please use actions/github-script, instead.

So I've fixed the generated jobs to use actions/github-script.

https://github.com/miyajan/test-shipjs/pull/1
I have tested the fixed create_done_comment and create_fail_comment jobs on my test repository to make sure they work correctly.

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, thanks!

@Haroenv Haroenv merged commit 4f56bdb into algolia:main Nov 3, 2020
@miyajan miyajan deleted the use-github-script-instead-of-deprecated-action branch November 3, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants