This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(refinementList): avoid unwanted spacing #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure it's not the other newline that's causing the space? |
Haroenv
suggested changes
Feb 2, 2018
Haroenv
approved these changes
Mar 5, 2018
|
I took another look now, and found the correct newline to remove. Annoying that the indentation looks a bit funky now, but at least there's no stray newline anymore. Waiting for the tests to be ran to merge this |
Haroenv
changed the title
Haroenv
pushed a commit
that referenced
this pull request
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #381