Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass arrays by reference to functions #172

Closed
wants to merge 3 commits into from
Closed

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Oct 18, 2023

closes #160

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for tealscript ready!

Name Link
🔨 Latest commit 9f9e697
🔍 Latest deploy log https://app.netlify.com/sites/tealscript/deploys/652fd108faebe30008e9dd99
😎 Deploy Preview https://deploy-preview-172--tealscript.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joe-p joe-p marked this pull request as draft October 18, 2023 19:36
@joe-p
Copy link
Contributor Author

joe-p commented Oct 18, 2023

This turns out to be more difficult than initially thought. Simply saving the arrays afterwards is difficult to do for array references. It is technically possible, but would require some significant refactoring around how array values are updated. For now, #173 blocks the developer from passing arrays to function without the use of clone, which means that this issue is no longer blocking a stable release.

@joe-p
Copy link
Contributor Author

joe-p commented Oct 29, 2023

Closing this since there is no plan to continue work any time soon

@joe-p joe-p closed this Oct 29, 2023
@joe-p joe-p deleted the feat/array_arg_ref branch December 28, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow mutation of array arguments
1 participant