Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint-fix support to the run commands #62

Open
neilcampbell opened this issue Mar 21, 2024 · 2 comments
Open

Add lint-fix support to the run commands #62

neilcampbell opened this issue Mar 21, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@neilcampbell
Copy link
Contributor

neilcampbell commented Mar 21, 2024

Once we have the changes in #61 merged, we'll likely have ideas for other run commands we want to add.

An examples of this is lint-fix, which would look something like below:

lint-fix = { commands = [
  'poetry run black .',
  'poetry run ruff . --fix',
  'poetry run mypy',
], description = 'Perform linting with --fix' }

We'll need to also add this to the other python template with the lint run command.

@neilcampbell neilcampbell added the enhancement New feature or request label Mar 21, 2024
@neilcampbell neilcampbell added this to the Enhancements milestone Mar 21, 2024
@CiottiGiorgio
Copy link
Member

With the assumption that lint-fix is something you want to run frequently when developing (or setting up a watch process that does it automatically), I think we can consider not calling mypy because there's no "fix" option for it.
What do you think?

@neilcampbell
Copy link
Contributor Author

@CiottiGiorgio Yeah I think that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants