Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert test template to create rather than deploy #8

Open
CiottiGiorgio opened this issue Mar 22, 2024 · 1 comment
Open

Revert test template to create rather than deploy #8

CiottiGiorgio opened this issue Mar 22, 2024 · 1 comment
Labels
question Further information is requested

Comments

@CiottiGiorgio
Copy link
Member

I've noticed the switch from .create() to

client.deploy(
    on_schema_break=algokit_utils.OnSchemaBreak.AppendApp,
    on_update=algokit_utils.OnUpdate.AppendApp,
)
return client

Personally I am used to and I see .create() more fit in the context of unit testing. What was the reason for this change?
I'm asking because I've been bit by instances where I'm only changing the test (and not the contract) and I was getting wrong results because of initial funding and/or previous state/boxes in the previous deployment.

@robdmoore
Copy link

@aorumbayev can you weigh in here please?

@robdmoore robdmoore added the question Further information is requested label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants